chore: remove diagnostic set -x tracing from runsteps.sh - #105
Merged
Merged
Conversation
Root cause found: the remaining Docker test failures are a pre-existing, known Unity licensing issue (game-ci/unity-test-runner#265, open since March 2024), not a bug in this repo. The activate step succeeds, but a separate unity-editor invocation for the actual test run sometimes gets 'License is not active (com.unity.editor.headless)' from a fresh licensing daemon - documented as happening ~30% of the time even on the original (pre-thin-wrapper) action, more frequently under concurrent test runs (which a full CI matrix of ~85 parallel jobs against the same Unity license is exactly). Not something to chase further in this repo - tracing has served its purpose.
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Root cause found: the remaining Docker test failures on
unity-test-runner's thin-wrapper PR (#310) are a pre-existing, known Unity licensing issue — unity-test-runner#265, open since March 2024, not a bug in this repo.The activate step succeeds, but a separate
unity-editorinvocation for the actual test run sometimes getsLicense is not active (com.unity.editor.headless)from a fresh licensing daemon. #265 documents this happening ~30% of the time even on the original (pre-thin-wrapper) action, and the reporter suspected it's more frequent under concurrent test runs — which a full CI matrix of ~85 parallel jobs against the same Unity license is exactly.Not something to chase further in this repo. Tracing has served its purpose (found and helped fix #96, #97, #101).
🤖 Generated with Claude Code