Skip to content

Add EFGs from MAS - #987

Merged
rahulsavani merged 6 commits into
gambitproject:masterfrom
wyz2368:add_mas_efgs
Jul 10, 2026
Merged

Add EFGs from MAS#987
rahulsavani merged 6 commits into
gambitproject:masterfrom
wyz2368:add_mas_efgs

Conversation

@wyz2368

@wyz2368 wyz2368 commented Jul 10, 2026

Copy link
Copy Markdown
Contributor
  1. Add EFGs from MAS and some original layouts.
  2. Fix Rahul's comment about imperfect recall and overlapped information sets.

@tturocy
tturocy requested a review from rahulsavani July 10, 2026 11:25
@tturocy

tturocy commented Jul 10, 2026

Copy link
Copy Markdown
Member

@rahulsavani What do you think about the slug for the textbook (shohambrown)?

@tturocy tturocy added this to the gambit-16.7.0 milestone Jul 10, 2026
@rahulsavani

Copy link
Copy Markdown
Member

@tturocy

@rahulsavani What do you think about the slug for the textbook (shohambrown)?

Good point -- I'd totally missed that and would prefer, e.g., shohamleytonbrown2008, even though it's much longer. What do you think? Any better ideas?

@tturocy

tturocy commented Jul 10, 2026

Copy link
Copy Markdown
Member

@tturocy

@rahulsavani What do you think about the slug for the textbook (shohambrown)?

Good point -- I'd totally missed that and would prefer, e.g., shohamleytonbrown2008, even though it's much longer. What do you think? Any better ideas?

Given our conventions so far that would be what we would use; as we build the catalog going towards 17.0 we might review this and think if there's some convention for abbreviations before we start getting inconveniently long canonical names.

@rahulsavani

Copy link
Copy Markdown
Member

@tturocy

@rahulsavani What do you think about the slug for the textbook (shohambrown)?

Good point -- I'd totally missed that and would prefer, e.g., shohamleytonbrown2008, even though it's much longer. What do you think? Any better ideas?

Given our conventions so far that would be what we would use; as we build the catalog going towards 17.0 we might review this and think if there's some convention for abbreviations before we start getting inconveniently long canonical names.

@wyz2368 OK, please update the slug:

shohambrown -> shohamleytonbrown

@wyz2368

wyz2368 commented Jul 10, 2026

Copy link
Copy Markdown
Contributor Author

@tturocy @rahulsavani Updated.

@rahulsavani rahulsavani left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The "original layout" version of fig6_8 now looks good to me, thanks. The "default" version still has the overlappying infosets -- can you fix that one. I saw you changed gtdraw_settings.yaml, but it seems those settings do not fix this.

@rahulsavani

Copy link
Copy Markdown
Member

The "original layout" version of fig6_8 now looks good to me, thanks. The "default" version still has the overlappying infosets -- can you fix that one. I saw you changed gtdraw_settings.yaml, but it seems those settings do not fix this.

sublevel_scaling is probably sufficient to fix this.

@wyz2368

wyz2368 commented Jul 10, 2026

Copy link
Copy Markdown
Contributor Author

@rahulsavani I forgot to update the slug for the fig6_8 setting. Now it should work. Please check.

Screenshot 2026-07-10 at 12 16 23 PM Screenshot 2026-07-10 at 12 16 41 PM

@rahulsavani rahulsavani left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@rahulsavani
rahulsavani merged commit e962da7 into gambitproject:master Jul 10, 2026
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants