Skip to content

Revert #643 (overlay generation guard) #646

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jackgallant merged 1 commit into from
Jun 1, 2026
Merged

Revert #643 (overlay generation guard) #646

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 1 addition & 7 deletions cortex/webgl/resources/js/svgoverlay.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,17 +114,11 @@ var svgoverlay = (function(module) {
this.svg.setAttribute("height", this.height);
},
module.SVGOverlay.prototype.update = function() {
// Re-bake the SVG overlay into a GPU texture asynchronously (toDataURL -> Image.onload).
// Rapid layer toggles (ROIs / sulci / labels) can kick off several bakes that finish out
// of order, leaving a stale texture on the surface that disagrees with the switch state.
// Tag each bake with a generation id and commit only the most recent one.
var gen = (this._updateGen = (this._updateGen || 0) + 1);
console.log("Updating overlay!");
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot Jun 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The console.log statement appears to be a leftover debug log. It is recommended to remove it to avoid cluttering the browser console in production environments.

this.svg.toDataURL("image/png", {renderer:"native", callback:function(dataurl) {
var img = new Image();
//img.src = dataurl;
img.onload = function () {
if (gen !== this._updateGen)
return; // superseded by a newer toggle -- discard this stale bake
var tex = new THREE.Texture(img);
tex.needsUpdate = true;
//tex.anisotropy = 16;
Expand Down