Revert #643 (overlay generation guard)#646
Merged
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request removes the generation-based update tracking mechanism from the SVG overlay update function, which previously prevented stale textures from being committed during rapid layer toggles. Additionally, a debug console.log statement was introduced. The reviewer recommends removing this leftover debug log to avoid cluttering the console in production.
| // of order, leaving a stale texture on the surface that disagrees with the switch state. | ||
| // Tag each bake with a generation id and commit only the most recent one. | ||
| var gen = (this._updateGen = (this._updateGen || 0) + 1); | ||
| console.log("Updating overlay!"); |
Contributor
There was a problem hiding this comment.
The console.log statement appears to be a leftover debug log. It is recommended to remove it to avoid cluttering the browser console in production environments.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #643 at the maintainer's request, returning the WebGL overlay code to its pre-change state. With #644 already reverted (#645), this restores
svgoverlay.js/mriview.jsto exactly how they were before the 2026-06-01 overlay-toggle work. The overlay toggle issues remain open for a future, browser-verified fix.🤖 Generated with Claude Code