Skip to content

Revert #644 (overlay redraw) — incomplete, regresses ROI labels#645

Merged
jackgallant merged 1 commit into
mainfrom
claude/revert-overlay-redraw
Jun 1, 2026
Merged

Revert #644 (overlay redraw) — incomplete, regresses ROI labels#645
jackgallant merged 1 commit into
mainfrom
claude/revert-overlay-redraw

Conversation

@jackgallant
Copy link
Copy Markdown
Contributor

Reverts #644. The surf "update" -> schedule() redraw fixes the overlay not redrawing on toggle, but it's incomplete: ROI label text textures are generated asynchronously in Labels.update (svg.toDataURL -> set_tex) and set_tex doesn't schedule a redraw. #644 forces a redraw the instant the overlay rebakes — usually before the label texture has loaded — so the label shader samples an empty texture and renders black squares that persist (nothing redraws again). Observed on the static make_static viewers (e.g. chen-2024) on load.

The generation guard (#643) is correct and stays. A complete fix must also redraw when each label texture finishes loading (touches the Labels class) and needs in-browser verification before landing — deferred.

🤖 Generated with Claude Code

@jackgallant jackgallant merged commit bd90468 into main Jun 1, 2026
12 checks passed
@jackgallant jackgallant deleted the claude/revert-overlay-redraw branch June 1, 2026 18:11
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes the 'update' event listener registration and its associated comment from the surface initialization in cortex/webgl/resources/js/mriview.js. There are no review comments, and I have no feedback to provide.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant