Skip to content

ci(dprint): check every tracked file in the format-check job #448

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
furedea merged 2 commits into from
Nov 10, 2026
Merged

ci(dprint): check every tracked file in the format-check job #448

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5cf67c9
ci(dprint): move dprint.json to the repository root
furedea Nov 10, 2026
897a953
docs(readme): drop the removed dprint directory from the tree
furedea Nov 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -205,7 +205,7 @@ jobs:
uses: furedea/reusable-workflows/.github/actions/nix-setup@2ae953294b9a805d0705657adc1d9d4f1bc1f646 # v1.3.0

- name: Run dprint
run: dprint check --config dprint/dprint.json --incremental=false
run: dprint check --incremental=false

- name: Run autocorrect
run: autocorrect . --lint --no-diff-bg-color
Expand Down
3 changes: 1 addition & 2 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -225,7 +225,7 @@ The following repository sources are linked directly into the home directory:
| `ghostty/config` | `~/.config/ghostty/config` |
| `karabiner/karabiner.json` | `~/.config/karabiner/karabiner.json` |
| `herdr/config.toml`, `herdr/reviewr.toml` | Herdr config and reviewr plugin config |
| `dprint/dprint.json` | `~/dprint.json` |
| `dprint.json` | `~/dprint.json` |

@github-actions github-actions Bot Nov 10, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P3: This row is updated, but the directory tree further down in the README (around line 252) still lists ├── dprint/ # Global formatter configuration. That directory no longer exists after this PR, so the tree now points at a missing path. Consider removing that entry, or replacing it with a dprint.json file entry.

| `.editorconfig` | `~/.editorconfig` |

Git, GitHub CLI, Lazygit, Atuin, Yazi, Zsh plugin paths, and rendered agent files
Expand All @@ -249,7 +249,6 @@ reference files.
├── starship/ # Shell prompt
├── github/ # Repository creation and policy scripts
├── tests/ # Python contracts and Bats integration by domain
├── dprint/ # Global formatter configuration
└── tinycast/ # Manual settings export
```

Expand Down
0 dprint/dprint.json → dprint.json
View file
Open in desktop
File renamed without changes.
2 changes: 1 addition & 1 deletion lefthook.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ pre-commit:
run: autocorrect --lint {all_files}
dprint:
glob: "*.{json,toml,md}"
run: dprint check --config ~/dprint.json {all_files}
run: dprint check {all_files}
# ----- lint -----
shellcheck:
glob: "*.sh"
Expand Down
2 changes: 1 addition & 1 deletion nix/home/default.nix
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -791,7 +791,7 @@ in
".vimrc".source = link "vim/.vimrc";

# dprint (global formatter config — dprint looks for ~/dprint.json by default)
"dprint.json".source = link "dprint/dprint.json";
"dprint.json".source = link "dprint.json";

# EditorConfig (global fallback for projects without their own)
".editorconfig".source = link ".editorconfig";
Expand Down
4 changes: 2 additions & 2 deletions tests/esa/format.bats
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ setup() {
}

format_markdown() {
dprint fmt --config "$REPO_ROOT/dprint/dprint.json" --stdin article.md
dprint fmt --config "$REPO_ROOT/dprint.json" --stdin article.md
}

@test "Markdown formatting preserves line breaks in esa prose" {
Expand All @@ -29,7 +29,7 @@ format_markdown() {
local _outside="$BATS_TEST_TMPDIR/outside/post.md"
mkdir -p "${_outside%/*}"

run --separate-stderr dprint fmt --config "$REPO_ROOT/dprint/dprint.json" --stdin "$_outside" < <(printf -- '- parent\n - child\n')
run --separate-stderr dprint fmt --config "$REPO_ROOT/dprint.json" --stdin "$_outside" < <(printf -- '- parent\n - child\n')

[ "$status" -eq 0 ]
[ "$output" = $'- parent\n - child' ]
Expand Down
Loading