Repository navigation
ci(dprint): check every tracked file in the format-check job - #448
Conversation
|
@codex review |
Codex Review Summary: ❌ FailedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Review summaryNo blocking findings.
🤖 Generated with Claude Code |
dprint resolves includes relative to the config file's directory, so the CI step matched only dprint/dprint.json. Placing the config at the root makes every tracked JSON/TOML/Markdown file a target and lets CI and lefthook auto-detect it. The ~/dprint.json link keeps the same content. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
d2bc91f to
5cf67c9
Compare
|
@codex review |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| | `karabiner/karabiner.json` | `~/.config/karabiner/karabiner.json` | | ||
| | `herdr/config.toml`, `herdr/reviewr.toml` | Herdr config and reviewr plugin config | | ||
| | `dprint/dprint.json` | `~/dprint.json` | | ||
| | `dprint.json` | `~/dprint.json` | |
There was a problem hiding this comment.
P3: This row is updated, but the directory tree further down in the README (around line 252) still lists ├── dprint/ # Global formatter configuration. That directory no longer exists after this PR, so the tree now points at a missing path. Consider removing that entry, or replacing it with a dprint.json file entry.
Review summaryNo blocking findings. Moving the config to the repository root fixes the root cause: dprint resolves
Findings:
|
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
|
@codex review |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
Review summary No findings. I checked these:
Blocking findings (P0/P1): 0 |
概要
CI の dprint ステップが tracked の JSON/TOML/Markdown をほぼチェックしていなかった問題を修正する．
原因は設定ファイルが
dprint/サブディレクトリにあり，dprint がincludesを設定ファイルのディレクトリ基準で解決することだった．対象はdprint/dprint.json自身の 1 ファイルだけになっていた．回避スクリプトではなく，設定をリポジトリのルートへ移して原因を取り除く．変更内容
dprint/dprint.json./dprint.json~/dprint.jsondprint/dprint.jsonへのリンク./dprint.jsonへのリンク（中身は同じ）dprint check --config dprint/dprint.jsondprint check --incremental=false--config ~/dprint.jsonnix/home/default.nixのリンク元，README の表，tests/esa/format.batsの参照を更新git grep "dprint/dprint.json"は 0 件不採用にした案
git ls-filesを位置引数で渡すスクリプトと専用 bats: 原因を残したままの回避策になるextendsだけの設定を置く: dprint が extends 先のincludesを拒否する（Unexpected non-string, boolean, or int property (includes)）証拠
dprint output-file-paths（リポジトリルート）dprint/dprint.json）git ls-files '*.json' '*.toml' '*.md'との差分dprint check --incremental=falseが exit 20 で失敗することを確認nix flake checkが成功（Home Manager のリンクが評価できる）tests/esa/format.bats3 件が成功Closes #439
🤖 Generated with Claude Code