Skip to content

Remove hlint ignore now fix has merged#1726

Merged
nficca merged 1 commit into
masterfrom
fossa/philderbeast/remove-hlint-ignore
Jun 30, 2026
Merged

Remove hlint ignore now fix has merged#1726
nficca merged 1 commit into
masterfrom
fossa/philderbeast/remove-hlint-ignore

Conversation

@nficca

@nficca nficca commented Jun 30, 2026

Copy link
Copy Markdown
Contributor

Overview

Re-opens #1723 from @philderbeast so CI runs (the original is from a fork). The commit is cherry-picked here unchanged.

The change removes a stale .hlint.yaml ignore directive that suppressed a false-positive "Unused LANGUAGE pragma" hint on App.Version and App.Version.TH. That hint came from an HLint bug with typed TH splices (hlint#1531). The fix shipped in HLint 3.8 and 3.10, and the directive's own comment said to remove it once that landed in haskell-dev-tools.

Acceptance criteria

HLint no longer reports "Unused LANGUAGE pragma", and make lint / make lint-haskell pass with the directive gone.

Testing plan

  1. From the repo root, run make lint-haskell (or the quicker hlint -j .).
  2. Confirm it passes with no "Unused LANGUAGE pragma" hints for App.Version or App.Version.TH.

Verified locally with HLint 3.8: running hlint on src/App/Version.hs and src/App/Version/TH.hs with the directive removed produces no "Unused LANGUAGE pragma" (only globally-ignored "Redundant bracket" hints). The authoritative check is the linter CI job, which runs in the haskell-dev-tools:9.8.4 container.

Risks

None worth calling out. Config-only change, and the linter CI job is the gate.

Metrics

N/A.

References

Checklist

  • I added tests for this PR's change (or explained in the PR description why tests don't make sense). Lint-config removal; the linter itself is the check.
  • If this PR introduced a user-visible change, I added documentation into docs/.
  • If this PR added docs, I added links as appropriate to the user manual's ToC in docs/README.ms and gave consideration to how discoverable or not my documentation is.
  • If this change is externally visible, I updated Changelog.md. If this PR did not mark a release, I added my changes into an ## Unreleased section at the top.
  • If I made changes to .fossa.yml or fossa-deps.{json.yml}, I updated docs/references/files/*.schema.json AND I have updated example files used by fossa init command. You may also need to update these if you have added/removed new dependency type (e.g. pip) or analysis target type (e.g. poetry).
  • If I made changes to a subcommand's options, I updated docs/references/subcommands/<subcommand>.md.

- hlint-3.8 and hlint-3.10 has this fix
@nficca nficca marked this pull request as ready for review June 30, 2026 14:58
@nficca nficca requested a review from a team as a code owner June 30, 2026 14:58
@nficca nficca requested a review from csasarak June 30, 2026 14:58
@coderabbitai

coderabbitai Bot commented Jun 30, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: ASSERTIVE

Plan: Pro

Run ID: 59e430bb-b50f-44cc-b62d-e801b6f72597

📥 Commits

Reviewing files that changed from the base of the PR and between b5a1c53 and 0055119.

📒 Files selected for processing (1)
  • .hlint.yaml
💤 Files with no reviewable changes (1)
  • .hlint.yaml

Walkthrough

The .hlint.yaml file had an ignore rule suppressing the "Unused LANGUAGE pragma" HLint warning for App.Version.TH and App.Version. This rule has been removed, re-enabling that warning for those modules.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately summarizes the main change: removing the stale HLint ignore after the underlying fix landed.
Description check ✅ Passed The description follows the template and covers overview, acceptance criteria, testing, risks, metrics, references, and checklist.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@nficca nficca merged commit 0de9084 into master Jun 30, 2026
19 of 20 checks passed
@nficca nficca deleted the fossa/philderbeast/remove-hlint-ignore branch June 30, 2026 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants