Remove hlint ignore now fix has merged#1726
Merged
Merged
Conversation
- hlint-3.8 and hlint-3.10 has this fix
6 tasks
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Organization UI (inherited) Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (1)
💤 Files with no reviewable changes (1)
WalkthroughThe 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
csasarak
approved these changes
Jun 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Re-opens #1723 from @philderbeast so CI runs (the original is from a fork). The commit is cherry-picked here unchanged.
The change removes a stale
.hlint.yamlignore directive that suppressed a false-positive "Unused LANGUAGE pragma" hint onApp.VersionandApp.Version.TH. That hint came from an HLint bug with typed TH splices (hlint#1531). The fix shipped in HLint 3.8 and 3.10, and the directive's own comment said to remove it once that landed in haskell-dev-tools.Acceptance criteria
HLint no longer reports "Unused LANGUAGE pragma", and
make lint/make lint-haskellpass with the directive gone.Testing plan
make lint-haskell(or the quickerhlint -j .).App.VersionorApp.Version.TH.Verified locally with HLint 3.8: running hlint on
src/App/Version.hsandsrc/App/Version/TH.hswith the directive removed produces no "Unused LANGUAGE pragma" (only globally-ignored "Redundant bracket" hints). The authoritative check is the linter CI job, which runs in thehaskell-dev-tools:9.8.4container.Risks
None worth calling out. Config-only change, and the linter CI job is the gate.
Metrics
N/A.
References
Checklist
docs/.docs/README.msand gave consideration to how discoverable or not my documentation is.Changelog.md. If this PR did not mark a release, I added my changes into an## Unreleasedsection at the top..fossa.ymlorfossa-deps.{json.yml}, I updateddocs/references/files/*.schema.jsonAND I have updated example files used byfossa initcommand. You may also need to update these if you have added/removed new dependency type (e.g.pip) or analysis target type (e.g.poetry).docs/references/subcommands/<subcommand>.md.