Skip to content

Remove hlint ignore now fix has merged#1723

Closed
philderbeast wants to merge 1 commit into
fossas:masterfrom
up-do:fix/redundant-ignore-unused-LANGUAGE-pragma
Closed

Remove hlint ignore now fix has merged#1723
philderbeast wants to merge 1 commit into
fossas:masterfrom
up-do:fix/redundant-ignore-unused-LANGUAGE-pragma

Conversation

@philderbeast

Copy link
Copy Markdown
Contributor

Overview

In .hlint.yaml I saw the comment, checked the versions of HLint used by .github/workflows/lint.yml and by make lint-haskell (make lint requires lint-haskell). I checked the fix commit, ndmitchell/hlint@505a4d5, and this has tags for 3.8 and 3.10.

$ make lint-haskell
Running hlint
HLint v3.10, (C) Neil Mitchell 2006-2025
...

Acceptance criteria

HLint doesn't suggest "Unused LANGUAGE pragma".

Testing plan

Run make lint or make lint-haskell locally. Also hlint -j . will do too. This latter check is quicker and runs in 8s rather than the 38s of make lint-haskell.

Checklist

  • I added tests for this PR's change (or explained in the PR description why tests don't make sense).
  • If this PR introduced a user-visible change, I added documentation into docs/.
  • If this PR added docs, I added links as appropriate to the user manual's ToC in docs/README.ms and gave consideration to how discoverable or not my documentation is.
  • If this change is externally visible, I updated Changelog.md. If this PR did not mark a release, I added my changes into an ## Unreleased section at the top.
  • If I made changes to .fossa.yml or fossa-deps.{json.yml}, I updated docs/references/files/*.schema.json AND I have updated example files used by fossa init command. You may also need to update these if you have added/removed new dependency type (e.g. pip) or analysis target type (e.g. poetry).
  • If I made changes to a subcommand's options, I updated docs/references/subcommands/<subcommand>.md.

- hlint-3.8 and hlint-3.10 has this fix
@philderbeast philderbeast requested a review from a team as a code owner June 20, 2026 15:59
@philderbeast philderbeast requested a review from nficca June 20, 2026 15:59
@coderabbitai

coderabbitai Bot commented Jun 20, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: ASSERTIVE

Plan: Pro

Run ID: 91abd9b1-e9c5-4000-bd4d-1d3540a67ea0

📥 Commits

Reviewing files that changed from the base of the PR and between 52c2ae8 and 3312588.

📒 Files selected for processing (1)
  • .hlint.yaml
💤 Files with no reviewable changes (1)
  • .hlint.yaml

Walkthrough

Removes a two-line HLint ignore directive from .hlint.yaml that suppressed the "Unused LANGUAGE pragma" hint scoped to App.Version.TH and App.Version. All other HLint configuration entries remain unchanged.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title directly references the main change: removing an hlint ignore rule that was needed for a now-fixed issue.
Description check ✅ Passed The description includes Overview, Acceptance criteria, and Testing plan sections with concrete details. The Risks and Metrics sections are omitted but the core information is sufficient.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@nficca

nficca commented Jun 30, 2026

Copy link
Copy Markdown
Contributor

Hey, thanks for the contribution. Because of the way our CI works, PRs have to be made by a FOSSA employee. I pulled this change and made a new PR here: #1726, which I'll shepherd in. You will still be credited. Thanks again!

@nficca nficca closed this Jun 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants