Remove hlint ignore now fix has merged#1723
Conversation
- hlint-3.8 and hlint-3.10 has this fix
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Organization UI (inherited) Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (1)
💤 Files with no reviewable changes (1)
WalkthroughRemoves a two-line HLint 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Hey, thanks for the contribution. Because of the way our CI works, PRs have to be made by a FOSSA employee. I pulled this change and made a new PR here: #1726, which I'll shepherd in. You will still be credited. Thanks again! |
Overview
In
.hlint.yamlI saw the comment, checked the versions of HLint used by.github/workflows/lint.ymland bymake lint-haskell(make lintrequireslint-haskell). I checked the fix commit, ndmitchell/hlint@505a4d5, and this has tags for3.8and3.10.Acceptance criteria
HLint doesn't suggest "Unused LANGUAGE pragma".
Testing plan
Run
make lintormake lint-haskelllocally. Alsohlint -j .will do too. This latter check is quicker and runs in 8s rather than the 38s ofmake lint-haskell.Checklist
docs/.docs/README.msand gave consideration to how discoverable or not my documentation is.Changelog.md. If this PR did not mark a release, I added my changes into an## Unreleasedsection at the top..fossa.ymlorfossa-deps.{json.yml}, I updateddocs/references/files/*.schema.jsonAND I have updated example files used byfossa initcommand. You may also need to update these if you have added/removed new dependency type (e.g.pip) or analysis target type (e.g.poetry).docs/references/subcommands/<subcommand>.md.