Skip to content

fix: respect NO_COLOR environment variable in dev format #360

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
armorbreak001 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: respect NO_COLOR environment variable in dev format #360

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -212,6 +212,9 @@ morgan.format('dev', function developmentFormatLine (tokens, req, res) {
? res.statusCode
: undefined

// check for NO_COLOR environment variable (https://no-color.org)
var noColor = process.env.NO_COLOR != null

// get status color
var color = status >= 500 ? 31 // red
: status >= 400 ? 33 // yellow
Expand All @@ -220,12 +223,15 @@ morgan.format('dev', function developmentFormatLine (tokens, req, res) {
: 0 // no color

// get colored function
var fn = developmentFormatLine[color]
var fn = developmentFormatLine[color + (noColor ? '-nc' : '')]

if (!fn) {
// compile
fn = developmentFormatLine[color] = compile('\x1b[0m:method :url \x1b[' +
color + 'm:status\x1b[0m :response-time ms - :res[content-length]\x1b[0m')
fn = developmentFormatLine[color + (noColor ? '-nc' : '')] = compile(
noColor
? ':method :url :status :response-time ms - :res[content-length]'
: '\x1b[0m:method :url \x1b[' + color + 'm:status\x1b[0m :response-time ms - :res[content-length]\x1b[0m'
)
}

return fn(tokens, req, res)
Expand Down