fix: respect NO_COLOR environment variable in dev format#360
Open
armorbreak001 wants to merge 1 commit into
Open
fix: respect NO_COLOR environment variable in dev format#360armorbreak001 wants to merge 1 commit into
armorbreak001 wants to merge 1 commit into
Conversation
When the NO_COLOR environment variable is set (per https://no-color.org/), the dev format now outputs plain text instead of ANSI-colored output. This improves accessibility for users with limited vision who may have difficulty reading colored terminal output. Fixes expressjs#302
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
devformat always outputs ANSI-colored text, ignoring the widely-adoptedNO_COLORenvironment variable (https://no-color.org/).This causes accessibility issues for users with limited vision who may have difficulty reading colored terminal output.
Fix
When
NO_COLORis set (even to an empty string), thedevformat outputs plain text without ANSI escape codes.Changes
devformat function inindex.jsto checkprocess.env.NO_COLOR-ncsuffix to separate plain-text and colored compiled formatsTesting
Fixes #302