Skip to content

🐛 FIX: html_block: blank lines inside containers prematurely terminate non-blank-line-terminator sequences #406

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gaoflow wants to merge 1 commit into
base: master
Choose a base branch
from
+25 −1
Open

🐛 FIX: html_block: blank lines inside containers prematurely terminate non-blank-line-terminator sequences #406

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion markdown_it/rules_block/html_block.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ def html_block(state: StateBlock, startLine: int, endLine: int, silent: bool) ->
# Let's roll down till block end.
if not html_seq[1].search(lineText):
while nextLine < endLine:
if state.sCount[nextLine] < state.blkIndent:
if state.sCount[nextLine] < state.blkIndent and not state.isEmpty(nextLine):
break

pos = state.bMarks[nextLine] + state.tShift[nextLine]
Expand Down
24 changes: 24 additions & 0 deletions tests/test_port/fixtures/commonmark_extras.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -749,3 +749,27 @@ Issue #204. Combination of blockquotes, list and newlines causes an IndexError
</li>
</ul>
.

Issue #377. HTML comment block inside list item should not end at blank line
.
1. item

<!--
comment with

blank line inside
-->
paragraph
.
<ol>
<li>
<p>item</p>
<!--
comment with

blank line inside
-->
<p>paragraph</p>
</li>
</ol>
.