-
-
Notifications
You must be signed in to change notification settings - Fork 26
Configure data explorer response views #85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
66 changes: 66 additions & 0 deletions
66
thingifier/src/main/java/uk/co/compendiumdev/thingifier/htmlgui/ThingifierGuiConfig.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,66 @@ | ||
| package uk.co.compendiumdev.thingifier.htmlgui; | ||
|
|
||
| import java.util.HashMap; | ||
| import java.util.Map; | ||
| import java.util.Optional; | ||
| import uk.co.compendiumdev.thingifier.core.domain.definitions.EntityDefinition; | ||
| import uk.co.compendiumdev.thingifier.core.domain.definitions.EntityViewDefinition; | ||
|
|
||
| public final class ThingifierGuiConfig { | ||
|
|
||
| private final DataExplorerConfig dataExplorer; | ||
|
|
||
| public ThingifierGuiConfig() { | ||
| dataExplorer = new DataExplorerConfig(); | ||
| } | ||
|
|
||
| public DataExplorerConfig dataExplorer() { | ||
| return dataExplorer; | ||
| } | ||
|
|
||
| public static final class DataExplorerConfig { | ||
| private final Map<String, String> responseViewNamesByEntity; | ||
|
|
||
| private DataExplorerConfig() { | ||
| responseViewNamesByEntity = new HashMap<>(); | ||
| } | ||
|
|
||
| public DataExplorerConfig responseView(final String entityName, final String viewName) { | ||
| final String normalizedEntityName = normalize(entityName); | ||
| final String normalizedViewName = viewName == null ? "" : viewName.trim(); | ||
| if (normalizedEntityName.isEmpty()) { | ||
| throw new IllegalArgumentException("Entity name is required"); | ||
| } | ||
| if (normalizedViewName.isEmpty()) { | ||
| throw new IllegalArgumentException("View name is required"); | ||
| } | ||
| responseViewNamesByEntity.put(normalizedEntityName, normalizedViewName); | ||
| return this; | ||
| } | ||
|
|
||
| public Optional<String> responseViewNameFor(final EntityDefinition definition) { | ||
| if (definition == null) { | ||
| return Optional.empty(); | ||
| } | ||
| String viewName = responseViewNamesByEntity.get(normalize(definition.getName())); | ||
| if (viewName == null) { | ||
| viewName = responseViewNamesByEntity.get(normalize(definition.getPlural())); | ||
| } | ||
| return Optional.ofNullable(viewName); | ||
| } | ||
|
|
||
| public EntityViewDefinition responseViewFor(final EntityDefinition definition) { | ||
| if (definition == null) { | ||
| return null; | ||
| } | ||
| return responseViewNameFor(definition) | ||
| .filter(definition::hasViewNamed) | ||
| .map(definition::getViewNamed) | ||
| .orElse(null); | ||
| } | ||
|
|
||
| private static String normalize(final String value) { | ||
| return value == null ? "" : value.trim().toLowerCase(); | ||
| } | ||
| } | ||
| } | ||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When a configured view name is misspelled, renamed, or registered against the wrong entity, this filter silently converts the configuration to
null;DefaultGuiHtmlPages.isResponseFieldVisibleand the JSON/XML converters interpretnullas no projection and render every field. A typo in a view intended to hide tokens or other internal data therefore fails open in the Data Explorer rather than producing a configuration error or an empty projection.Useful? React with 👍 / 👎.