Skip to content

Configure data explorer response views - #85

Merged
eviltester merged 1 commit into
masterfrom
codex/data-explorer-response-views
Jul 28, 2026
Merged

Configure data explorer response views#85
eviltester merged 1 commit into
masterfrom
codex/data-explorer-response-views

Conversation

@eviltester

Copy link
Copy Markdown
Owner

Summary

  • Add Thingifier GUI configuration for Data Explorer response views.
  • Project Data Explorer list/detail/relationship output through configured public views.
  • Keep entity definitions decoupled from UI/default response-view concerns.

Validation

  • mvn -q -pl ercoremodel,thingifier test
  • mvn -q -pl challenger "-Dtest=ShoppingCartApiTest,ShoppingCartDefaultGuiTest,ShoppingCartModelTest" test

Copilot AI review requested due to automatic review settings July 28, 2026 21:15

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@eviltester
eviltester merged commit 009af0a into master Jul 28, 2026
3 checks passed
@eviltester
eviltester deleted the codex/data-explorer-response-views branch July 28, 2026 21:16

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: b7c76762ef

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +56 to +59
return responseViewNameFor(definition)
.filter(definition::hasViewNamed)
.map(definition::getViewNamed)
.orElse(null);

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Reject unknown response views instead of exposing every field

When a configured view name is misspelled, renamed, or registered against the wrong entity, this filter silently converts the configuration to null; DefaultGuiHtmlPages.isResponseFieldVisible and the JSON/XML converters interpret null as no projection and render every field. A typo in a view intended to hide tokens or other internal data therefore fails open in the Data Explorer rather than producing a configuration error or an empty projection.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants