fix(tests): align Amsterdam (gas) tests with EIP-2780/8037/8038 - #3088
Merged
spencer-tb merged 6 commits intoJul 2, 2026
Conversation
The ancestor revert refills the state-gas charge, but Amsterdam still bills the EIP-8038 ACCOUNT_WRITE regular gas for the attempted value transfer to an empty account. Update the derived blockchain header expectation to match that accounting.
Invalid set-code authorizations are skipped, but the Amsterdam implementation refills their auth state gas and refunds ACCOUNT_WRITE. Update the receipt calculation and comments to match that accounting.
Amsterdam intrinsic gas changes made the regular-dominant block fall below the base-fee target. Derive the STOP transaction count from the target and intrinsic cost so the test keeps covering the intended dominant-dimension branch regardless of future intrinsic-gas changes.
The ported CREATE2 filler pinned a 1,000,000 block gas limit, too little for the EIP-8037 state gas that spills into the regular budget on Amsterdam. The test pins post-state, not a gas boundary, so omit the env `gas_limit` and let the framework supply its default block gas limit (ample regular budget plus state reservoir) on every fork.
EXTCODESIZE and EXTCODECOPY now include the EIP-8038 warm code-read charge. Derive the measured warm-access gas from `WARM_ACCESS` and gate the extra code-read on `fork.is_eip_enabled(8038)`, keeping the legacy expectation for earlier forks.
danceratopz
added
C-bug
20 tasks
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## eips/amsterdam/eip-2780-8038 #3088 +/- ##
================================================================
+ Coverage 92.89% 93.24% +0.34%
================================================================
Files 624 624
Lines 36979 36979
Branches 3381 3381
================================================================
+ Hits 34353 34482 +129
+ Misses 1788 1704 -84
+ Partials 838 793 -45
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
7 tasks
spencer-tb
merged commit Jul 2, 2026
bd52730
into
ethereum:eips/amsterdam/eip-2780-8038
18 checks passed
spencer-tb
pushed a commit
that referenced
this pull request
Jul 2, 2026
Co-authored-by: marioevz <marioevz@gmail.com>
marioevz
added a commit
that referenced
this pull request
Jul 2, 2026
* feat(spec-specs, tests): add EIP-8038 state-access gas cost update (#2972) Co-authored-by: Sam Wilson <57262657+SamWilsn@users.noreply.github.com> Co-authored-by: Mario Vega <11726710+marioevz@users.noreply.github.com> * feat(spec-specs, tests): Implement EIP-2780 (#3017) * chore(tests): fix failing ported static slow tests for EIP-8038 (#3019) Co-authored-by: marioevz <marioevz@gmail.com> * test(amsterdam): add EIP-8038 state-access gas cost tests (#3033) Co-authored-by: danceratopz <danceratopz@gmail.com> Co-authored-by: marioevz <marioevz@gmail.com> * fix(tests): account for EIP-8246 in EIP-8038 selfdestruct gas test (#3044) EIP-8246 removes the `SELFDESTRUCT` balance burn, which changes the same-transaction self-destruct-to-self outcome. Gate the affected expectations in `test_selfdestruct_gas.py` on `fork.is_eip_enabled(8246)` so the test holds on forks with and without EIP-8246: - Pre-EIP-8246: The originator balance is burnt (a `Burn` log) and the same-transaction-created account is deleted. - EIP-8246 onwards: The burn is removed, so the self-send is a no-op; the balance stays in the (emptied) originator and no log is emitted. `burn_log` is imported lazily in the pre-EIP-8246 branch because EIP-8246 deletes the helper from the EIP-7708 spec. The charged gas is unchanged, so `cumulative_gas_used` is asserted identically on both sides. * fix(spec-specs): EIP-2780 charge `NEW_ACCOUNT` for value transfer to zero balance precompile (#3048) * fix(amsterdam): charge NEW_ACCOUNT for value transfer to empty precompile EIP-2780 charges the NEW_ACCOUNT state cost when a transaction transfers value to a recipient that is empty per EIP-161. The top-frame charge previously carved out precompile recipients, but neither EIP-2780 nor EIP-161 authorizes that exemption: - EIP-2780 does not mention precompiles; its rule keys solely on "empty per EIP-161 and tx.value > 0". - EIP-161 defines empty structurally (no code, zero nonce, zero balance) with no precompile exception, so an unfunded precompile is empty and is created by the value transfer like any other account. Remove the `recipient_is_precompile` carve-out from the top-frame charge so an empty precompile receiving value pays NEW_ACCOUNT, drop the matching special-case from the testing framework's `transaction_top_frame_state_gas`, and rewrite `test_value_move_to_precompiles` to assert the charge fires for the not-funded precompile while a pre-funded (alive) precompile remains exempt by virtue of being non-empty. Co-authored-by: danceratopz <danceratopz@gmail.com> * feat(tests): add more EIP-2780 tests (#3055) Co-authored-by: danceratopz <danceratopz@gmail.com> Co-authored-by: Louis Tsai <72684086+LouisTsai-Csie@users.noreply.github.com> * feat(specs): update EIP-8037 impl for ethereum/EIPs#11715 (#3021) Co-authored-by: spencer-tb <spencer.tb@ethereum.org> * fix(tests): align Amsterdam (gas) tests with EIP-2780/8037/8038 (#3088) Co-authored-by: marioevz <marioevz@gmail.com> * Apply suggestions from code review (packates/testing) Co-authored-by: Mario Vega <marioevz@gmail.com> * Apply suggestions from code review (specs) Co-authored-by: Mario Vega <marioevz@gmail.com> * Apply suggestions from code review (tests) Co-authored-by: Mario Vega <marioevz@gmail.com> * fix(specs): Lint * fix(test-tools): Lint --------- Co-authored-by: Sam Wilson <57262657+SamWilsn@users.noreply.github.com> Co-authored-by: Mario Vega <11726710+marioevz@users.noreply.github.com> Co-authored-by: Guruprasad Kamath <guru241987@gmail.com> Co-authored-by: spencer <spencer.taylor-brown@ethereum.org> Co-authored-by: marioevz <marioevz@gmail.com> Co-authored-by: CPerezz <37264926+CPerezz@users.noreply.github.com> Co-authored-by: Guruprasad Kamath <48196632+gurukamath@users.noreply.github.com> Co-authored-by: Louis Tsai <72684086+LouisTsai-Csie@users.noreply.github.com> Co-authored-by: spencer-tb <spencer.tb@ethereum.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🗒️ Description
Fix-up 5 tests (filled at Amsterdam) that surfaced following the rebase of
eips/amsterdam/2780-8038onforks/amsterdam:test_selfdestruct_state_gas_refilled_on_ancestor_revert)test_mixed_validity_multi_auth_receipt_gas).test_create2check_fields_in_initcode,test_coinbase_warm_account_call_gas).test_base_fee_per_gas_follows_dominant_dimensionincluded following rebase:test_base_fee_per_gas_follows_dominant_dimensionnum_txs = 15gives15 * intrinsic = 225000 < 300000target7c634a428c6(#3039) added this test withnum_txs = 15, calibrated for the upstream21000intrinsic (15 * 21000 = 315000 > 300000)~15000)test_create2check_fields_in_initcode1_000_000gas limit too small for the CREATE2 children8dca7a70340(#2996) un-skipped it on Amsterdam (d0,d1,d2,d4,d5,d6)#3027spill refactor)test_coinbase_warm_account_call_gas100, measures200onEXTCODESIZE/EXTCODECOPY8dca7a70340(#2996) un-skipped it on Amsterdam (d0..d7)WARM_ACCESScode readtest_selfdestruct_state_gas_refilled_on_ancestor_revertACCOUNT_WRITE(8000)9920b6e67cb(#3027) reworked state-gas reservoir/spill, so the regularACCOUNT_WRITEnow surfaces in the headerACCOUNT_WRITEon empty-account SELFDESTRUCTtest_mixed_validity_multi_auth_receipt_gasb270a21e8ea(#3021, cherry-picked) reworkedset_delegation()refunds for skipped auths🔗 Related Issues or PRs
Targets:
✅ Checklist
just static<type>(<area>):, where<type>and<area>come from an approrpriateC-<type>, respectivelyA-<area>, label. The title should match the a target squash commit message.Cute Animal Picture