feat(spec-specs,test-tests): add EIP-2780 and EIP-8038 - #3052
Merged
Conversation
danceratopz
added
C-feat
20 tasks
danceratopz
force-pushed
the
eips/amsterdam/eip-2780-8038
branch
from
July 2, 2026 11:00
9765653 to
35a757b
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## forks/amsterdam #3052 +/- ##
================================================
Coverage 93.23% 93.24%
================================================
Files 624 624
Lines 36936 36986 +50
Branches 3375 3383 +8
================================================
+ Hits 34439 34489 +50
Misses 1704 1704
Partials 793 793
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Member
Author
|
Rebased on |
danceratopz
force-pushed
the
eips/amsterdam/eip-2780-8038
branch
from
July 2, 2026 12:26
35a757b to
b270a21
Compare
4 tasks
danceratopz
marked this pull request as ready for review
July 2, 2026 15:56
…2972) Co-authored-by: Sam Wilson <57262657+SamWilsn@users.noreply.github.com> Co-authored-by: Mario Vega <11726710+marioevz@users.noreply.github.com>
Co-authored-by: marioevz <marioevz@gmail.com>
Co-authored-by: danceratopz <danceratopz@gmail.com> Co-authored-by: marioevz <marioevz@gmail.com>
…3044) EIP-8246 removes the `SELFDESTRUCT` balance burn, which changes the same-transaction self-destruct-to-self outcome. Gate the affected expectations in `test_selfdestruct_gas.py` on `fork.is_eip_enabled(8246)` so the test holds on forks with and without EIP-8246: - Pre-EIP-8246: The originator balance is burnt (a `Burn` log) and the same-transaction-created account is deleted. - EIP-8246 onwards: The burn is removed, so the self-send is a no-op; the balance stays in the (emptied) originator and no log is emitted. `burn_log` is imported lazily in the pre-EIP-8246 branch because EIP-8246 deletes the helper from the EIP-7708 spec. The charged gas is unchanged, so `cumulative_gas_used` is asserted identically on both sides.
…zero balance precompile (#3048) * fix(amsterdam): charge NEW_ACCOUNT for value transfer to empty precompile EIP-2780 charges the NEW_ACCOUNT state cost when a transaction transfers value to a recipient that is empty per EIP-161. The top-frame charge previously carved out precompile recipients, but neither EIP-2780 nor EIP-161 authorizes that exemption: - EIP-2780 does not mention precompiles; its rule keys solely on "empty per EIP-161 and tx.value > 0". - EIP-161 defines empty structurally (no code, zero nonce, zero balance) with no precompile exception, so an unfunded precompile is empty and is created by the value transfer like any other account. Remove the `recipient_is_precompile` carve-out from the top-frame charge so an empty precompile receiving value pays NEW_ACCOUNT, drop the matching special-case from the testing framework's `transaction_top_frame_state_gas`, and rewrite `test_value_move_to_precompiles` to assert the charge fires for the not-funded precompile while a pre-funded (alive) precompile remains exempt by virtue of being non-empty. Co-authored-by: danceratopz <danceratopz@gmail.com>
Co-authored-by: danceratopz <danceratopz@gmail.com> Co-authored-by: Louis Tsai <72684086+LouisTsai-Csie@users.noreply.github.com>
Co-authored-by: spencer-tb <spencer.tb@ethereum.org>
Co-authored-by: marioevz <marioevz@gmail.com>
spencer-tb
force-pushed
the
eips/amsterdam/eip-2780-8038
branch
from
July 2, 2026 20:16
bd52730 to
ada583d
Compare
spencer-tb
added a commit
that referenced
this pull request
Jul 2, 2026
marioevz
approved these changes
Jul 2, 2026
marioevz
left a comment
marioevz
left a comment
Member
There was a problem hiding this comment.
Thanks! It's a lot of comments but in reality they are only stylistic comments, and most of them don't affect functionality.
Co-authored-by: Mario Vega <marioevz@gmail.com>
Co-authored-by: Mario Vega <marioevz@gmail.com>
Co-authored-by: Mario Vega <marioevz@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🗒️ Description
This is not ready to merge, as it stands, this PR mainly exists as a tracker for the remaining issues to get this into
forks/amsterdam#3088 is required before review
Possible to defer...
tests/ported_staticintroduced in 8038 fixups #3016🔗 Related Issues or PRs
✅ Checklist
just statictype(scope):.Cute Animal Picture