feat(email): remove circle around signer-verified checkmark#173
Merged
Conversation
The signer-verified circle previously rendered a unicode `✓` glyph which is styled inconsistently across mail clients. Embed a PNG of the PostGuard checkmark via `cid:pg-check` to match the shape used in the download page UI.
Contributor
|
Dobby has received the request! Routing to the right specialist now... |
…k-circle # Conflicts: # src/email.rs # templates/email/email.html
![dobby-coder[bot]](https://avatars.githubusercontent.com/in/3365457?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code review
Cosmetic email-template change; tests pass. Minor: build_body doc at src/email.rs:209 still names only cid:pg-logo though the function now also attaches cid:pg-check. PR description only covers the second commit — the cumulative diff against main also adds CHECK_PNG, templates/email/check.png, and the unicode→inline-PNG swap, so reviewers reading the description alone will miss those.
Rule compliance
No issues found.
| <span style="display:inline-block;width:32px;height:32px;line-height:32px;border-radius:50%;border:2px solid #5F7381;text-align:center;box-sizing:border-box;"> | ||
| <img src="cid:pg-check" alt="" width="16" height="13" style="display:inline-block;vertical-align:middle;" /> | ||
| </span> | ||
| <img src="cid:pg-check" alt="" width="16" height="13" style="display:inline-block;vertical-align:middle;" /> |
Contributor
There was a problem hiding this comment.
[Code review] alt="" treats the checkmark as decorative; consider alt="Verified" (or similar) so screen readers convey the signer-verified semantic that the styled circle previously implied.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CHECK_PNGdoc comment so it no longer references the removed circle.Test plan