Skip to content

feat(email): remove circle around signer-verified checkmark #173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rubenhensen merged 3 commits into from
Jun 4, 2026
Merged

feat(email): remove circle around signer-verified checkmark #173

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
560ea8f
feat(email): replace unicode checkmark with inline PNG image
rubenhensen Jun 4, 2026
d296260
feat(email): remove circle around signer-verified checkmark
rubenhensen Jun 4, 2026
b1768a4
Merge remote-tracking branch 'origin/main' into email-remove-checkmar…
rubenhensen Jun 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/email.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,7 @@ fn take_firstname_lastname_pair(attrs: &mut Vec<(String, String)>) -> Option<Str
/// HTML-only-plus-remote-image spam signal flagged in postguard#197.
const LOGO_PNG: &[u8] = include_bytes!("../templates/email/pg_logo.png");

/// Inline checkmark glyph used inside the signer-verified circle in the
/// Inline checkmark glyph shown next to the signer-verified email in the
/// HTML email, referenced via `cid:pg-check`. Replaces the previous
/// unicode `&#10003;` so the mark renders consistently across clients.
const CHECK_PNG: &[u8] = include_bytes!("../templates/email/check.png");
Expand Down
4 changes: 1 addition & 3 deletions templates/email/email.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,9 +42,7 @@
{% if sender_email != "" %}
<div style="margin-top:40px;padding-top:30px;border-top:1px solid #C6E2F6;text-align:center;">
<div style="margin-bottom:12px;">
<span style="display:inline-block;width:32px;height:32px;line-height:32px;border-radius:50%;border:2px solid #5F7381;text-align:center;box-sizing:border-box;">
<img src="cid:pg-check" alt="" width="16" height="13" style="display:inline-block;vertical-align:middle;" />
</span>
<img src="cid:pg-check" alt="" width="16" height="13" style="display:inline-block;vertical-align:middle;" />

@dobby-coder dobby-coder Bot Jun 4, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[Code review] alt="" treats the checkmark as decorative; consider alt="Verified" (or similar) so screen readers convey the signer-verified semantic that the styled circle previously implied.

</div>
<p style="font-size:13px;color:#5F7381;margin:0 0 6px 0;">{{files_from}}</p>
<p style="font-size:15px;font-weight:700;color:#030E17;margin:0 0 12px 0;">{{sender_email}}</p>
Expand Down