Skip to content

Add sirocco, passagemath-sirocco - #6026

Merged
IsabelParedes merged 6 commits into
emscripten-forge:mainfrom
passagemath:passagemath-sirocco
Jul 31, 2026
Merged

Add sirocco, passagemath-sirocco#6026
IsabelParedes merged 6 commits into
emscripten-forge:mainfrom
passagemath:passagemath-sirocco

Conversation

@mkoeppe

@mkoeppe mkoeppe commented Jul 25, 2026

Copy link
Copy Markdown
Contributor

Template A: Checklist for adding a package

Pre-submission Checks

  • Package requires building for emscripten-wasm32 platform (not a noarch package), in other words, the package requires compilation.

Recipe Structure

Added recipes/recipes_emscripten/[package-name]/recipe.yaml with proper structure:

  • context section with version (and optionally name)
  • package section with name and version using Jinja2 templates
  • source section with:
    • Source URL is valid and points to archive file (.tar.gz, .tar.bz2, .tar.xz, .tgz, or .zip)
    • Source URL contains ${{ version }} template for version updates
    • SHA256 hash is correct (verified with curl -sL <url> | sha256sum)
    • Patches (if any) are included in [package-name]/patches/ directory
  • build section with appropriate script/method
    • Python packages: ${PYTHON} -m pip install . ${PIP_ARGS}
    • R packages: $R CMD INSTALL $R_ARGS .
    • C++ packages: Uses emcmake/emmake or emconfigure/emmake
    • Rust packages: Uses rust-nightly and maturin or appropriate Rust build tool
    • Build number is 0
    • If the script is longer than 3 lines, a build.sh is included
  • requirements section (build, host, run as needed)
  • tests section
    • Python packages: test_import_[package].py file created and referenced
    • C++ packages: Test executable or package_contents test
    • R packages: Package contents test
  • about section with license, homepage, summary

PR Formatting

  • PR title follows format: Add [package-name] or Update [package-name] to [version]
  • PR description includes:
    • Version being added/updated
    • Any special build considerations or patches applied

Package Details

  • Package Name: sirocco, passagemath-sirocco
  • Version: 2.1.1, 10.8.7

Build Notes

FYI @miguelmarco

@mkoeppe

This comment was marked as resolved.

@mkoeppe

This comment was marked as resolved.

@wangyenshu

Copy link
Copy Markdown
Contributor

@wangyenshu The version of sirocco that you packaged in #6022 is outdated. The correct upstream is https://github.com/miguelmarco/SIROCCO2

Done.

@mkoeppe
mkoeppe marked this pull request as ready for review July 26, 2026 19:14
@mkoeppe
mkoeppe force-pushed the passagemath-sirocco branch from 70099a0 to 023d87a Compare July 30, 2026 19:34
@mkoeppe mkoeppe changed the title Add passagemath-sirocco Add sirocco, passagemath-sirocco Jul 30, 2026
@mkoeppe mkoeppe mentioned this pull request Jul 30, 2026
10 tasks

@IsabelParedes IsabelParedes left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@IsabelParedes
IsabelParedes merged commit c9bbd9c into emscripten-forge:main Jul 31, 2026
3 checks passed
@mkoeppe
mkoeppe deleted the passagemath-sirocco branch July 31, 2026 16:42
@mkoeppe

mkoeppe commented Jul 31, 2026

Copy link
Copy Markdown
Contributor Author

Thanks @IsabelParedes!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants