Skip to content

add eclib, sympow, sirocco, bliss - #6022

Closed
wangyenshu wants to merge 9 commits into
emscripten-forge:mainfrom
wangyenshu:eclib-sympow-sirocco-bliss
Closed

add eclib, sympow, sirocco, bliss#6022
wangyenshu wants to merge 9 commits into
emscripten-forge:mainfrom
wangyenshu:eclib-sympow-sirocco-bliss

Conversation

@wangyenshu

Copy link
Copy Markdown
Contributor

Pre-submission Checks

  • Package requires building for emscripten-wasm32 platform (not a noarch package), in other words, the package requires compilation.

Recipe Structure

Added recipes/recipes_emscripten/[package-name]/recipe.yaml with proper structure:

  • context section with version (and optionally name)
  • package section with name and version using Jinja2 templates
  • source section with:
    • Source URL is valid and points to archive file (.tar.gz, .tar.bz2, .tar.xz, .tgz, or .zip)
    • Source URL contains ${{ version }} template for version updates
    • SHA256 hash is correct (verified with curl -sL <url> | sha256sum)
    • Patches (if any) are included in [package-name]/patches/ directory
  • build section with appropriate script/method
    • Python packages: ${PYTHON} -m pip install . ${PIP_ARGS}
    • R packages: $R CMD INSTALL $R_ARGS .
    • C++ packages: Uses emcmake/emmake or emconfigure/emmake
    • Rust packages: Uses rust-nightly and maturin or appropriate Rust build tool
    • Build number is 0
    • If the script is longer than 3 lines, a build.sh is included
  • requirements section (build, host, run as needed)
  • tests section
    • Python packages: test_import_[package].py file created and referenced
    • C++ packages: Test executable or package_contents test
    • R packages: Package contents test
  • about section with license, homepage, summary

PR Formatting

  • PR title follows format: Add [package-name] or Update [package-name] to [version]
  • PR description includes:
    • Version being added/updated
    • Any special build considerations or patches applied

Package Details

  • Package Name: eclib, sympow, sirocco, bliss
  • Version: various, see their recipe

Build Notes

@mkoeppe

This comment was marked as resolved.

@mkoeppe

This comment was marked as resolved.

@wangyenshu

Copy link
Copy Markdown
Contributor Author

Fixed

@IsabelParedes IsabelParedes left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor changes. Thank you!

Comment thread recipes/recipes_emscripten/eclib/recipe.yaml
Comment on lines +23 to +24
cp libbliss.a $PREFIX/lib/
cp libbliss_static.a $PREFIX/lib/ || true

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These two libraries are identical. It would be better to make libbliss.a a shared library, aka a side module with correspoinding EM_FORGE_SIDE_MODULE_LDFLAGS.

And you can add this to the CMakeList

set_property(GLOBAL PROPERTY TARGET_SUPPORTS_SHARED_LIBS TRUE)

to fix

ADD_LIBRARY called with SHARED option but the target platform does not
support dynamic linking.  Building a STATIC library instead.  This may lead
to problems.

Co-authored-by: Isabel Paredes <isabel.paredes@quantstack.net>
@mkoeppe

mkoeppe commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

@wangyenshu wangyenshu closed this Jul 31, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants