Repository navigation
Support qunit 3 - #1206
Merged
Merged
Support qunit 3#1206
Conversation
kategengler
approved these changes
Sep 29, 2026
The new qunit-3 ember-try scenario runs the test app with qunit ^3.0.0. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
NullVoxPopuli-ai-agent
force-pushed
the
nvp/qunit-3
branch
from
September 29, 2026 22:00
4d1d7fd to
66b52ea
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
qunitpeer range is now^2.13.0 || ^3.0.0, and a newqunit-3ember-try scenario runs the test app against QUnit 3 in CI.This removes the unmet peer warning that new apps get from ember-cli/ember-app-blueprint#336.
ember-qunit needs no source changes. Every QUnit API it calls still exists in QUnit 3. QUnit 3 lowers the default test timeout to 3 seconds, but ember-qunit already sets it to 60 seconds.
Tested locally:
ember testintest-appwith qunit 2.25.0: 28 of 28 pass.ember try:one qunit-3with qunit 3.0.0: 28 of 28 pass, with the same test names and the same console output as the qunit 2 run.pnpm lintpasses. The lockfile does not change.Upgrade guide: https://qunitjs.com/upgrade-guide-3.x/
🤖 Generated with Claude Code