Repository navigation
Fix canary CI: update @ember/test-helpers to 5.5.2 - #1207
Merged
NullVoxPopuli merged 1 commit intoSep 29, 2026
Merged
Conversation
Ember canary no longer registers the `view:-outlet` factory. @ember/test-helpers 5.4.1 calls `.create` on it in setupRenderingContext, so every rendering test failed. 5.5.x renders with `renderComponent` on ember-source >= 6.12.0-alpha.4. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
kategengler
approved these changes
Sep 29, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
ember-canarytry scenario passes again after@ember/test-helpersgoes from^5.4.1to^5.5.2.Ember canary removed the
-outletview in emberjs/ember.js@e942972da4.@ember/test-helpers5.4.1 still callsowner.factoryFor('view:-outlet').create(...)insetupRenderingContext, so every rendering test failed:Version 5.5.x uses
renderComponentwhen the app runs ember-source>=6.12.0-alpha.4, and it keeps the old path for older Ember.Tested locally, 28 of 28 pass in each run:
ember testintest-appember-canary(7.5.0-alpha.1)ember-beta(7.4.0-beta.1)ember-release(7.3.0)ember-lts-5.12embroider-optimizedThis unblocks #1206.
🤖 Generated with Claude Code