Repository navigation
Upgrade qunit to v3 and ember-welcome-page to 8.0.6 in the app blueprint - #336
Merged
Merged
Conversation
ember-qunit 9.1.0 still declares qunit ^2.13.0 as a peer, so pnpm prints an unmet peer warning. The generated app tests pass with qunit 3.0.0. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Contributor
|
blocked on:
|
8.0.6 scopes its CSS under a body class that the component adds. Before, its global body rules loaded on /tests too and changed the QUnit page: a gray background and a lighter font weight. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
NullVoxPopuli-ai-agent
changed the title
Contributor
|
contrasts look good now |
ef4
approved these changes
Oct 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New apps get
qunit@^3.0.0instead of^2.26.0, andember-welcome-page@^8.0.6instead of^8.0.5.ember-welcome-page8.0.6 is required for a correct/testspage. Older versions load their globalbodyCSS on/teststoo. The QUnit page then gets a gray background and a light font weight, so the bold test names look normal. 8.0.6 scopes that CSS under a body class that the component adds (ember-cli/ember-welcome-page#423).ember-qunit9.2.0 accepts qunit 3 as a peer, sopnpm installin a new app prints no unmet peer warning. The template keeps^9.1.0, and a new install gets 9.2.0.QUnit 3 lowers the default test timeout to 3 seconds. This does not affect Ember apps, because
ember-qunitsets the timeout to 60 seconds.Tested locally:
pnpm vitest run: 36 of 36 pass, including the JS and TS app test runs and the/testsserving runs.qunit3.0.0,ember-qunit9.2.0 andember-welcome-page8.0.6, with no peer warnings./testshas the standard QUnit look (white background, bold test names), and/still shows the styled welcome page.Upgrade guide: https://qunitjs.com/upgrade-guide-3.x/
🤖 Generated with Claude Code