Preserve DOCX run boundaries on PM round trip#832
Conversation
|
@aldrinjenson is attempting to deploy a commit to the EigenPal Team on Vercel. A member of the Team first needs to authorize it. |
|
All contributors have signed the CLA ✍️ ✅ Posted by the CLA bot. |
|
Update after corpus verification: the original version only restored boundaries after Sanity check on the #830 attachment: raw Additional validation after the parser fix:
|
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
jedrazb
left a comment
There was a problem hiding this comment.
thanks for taking this on, the approach is solid. i like that it fails closed, and i couldn't get it to corrupt or duplicate content. requesting changes for a few things before merge:
- needs a rebase (behind main). since the parser de-consolidation is pipeline-wide, not just round-trip, please run the full playwright suite after rebasing, not only the conversion unit tests.
the rest are inline. nice work on the changeset, the regenerated api snapshots, and the stale-after-edit coverage.
|
Pushed e97ddd5 addressing the review comments. Validation run:
|
After the leading-page-break (#831) and run-boundary-preservation (#832) fixes both landed on main, the empty leading-break run is kept distinct, so the lastRenderedPageBreak marker serializes onto its own w:r instead of the text run. The output is valid OOXML; relax the over-specified assertion to check the marker and the text independently. Fixes red main. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
After the leading-page-break (#831) and run-boundary-preservation (#832) fixes both landed on main, the empty leading-break run is kept distinct, so the lastRenderedPageBreak marker serializes onto its own w:r instead of the text run. The output is valid OOXML; relax the over-specified assertion to check the marker and the text independently. Fixes red main. Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Summary
toProseDoc->fromProseDocround trips.Testing
bun run formatbun test packages/core/src/prosemirror/conversionbun run typecheckbun run check:paritybun run build:packagesbun run api:checkRefs #830
Need help on this PR? Tag
/codesmithwith what you need. Autofix is disabled.