test(conversion): fix red main from #831/#832 interaction#850
Merged
Conversation
After the leading-page-break (#831) and run-boundary-preservation (#832) fixes both landed on main, the empty leading-break run is kept distinct, so the lastRenderedPageBreak marker serializes onto its own w:r instead of the text run. The output is valid OOXML; relax the over-specified assertion to check the marker and the text independently. Fixes red main. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
|
All contributors have signed the CLA ✍️ ✅ Posted by the CLA bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The leading-page-break fix (#831) and run-boundary preservation (#832) both landed on main independently. Combined, the empty leading-break run is kept distinct, so the
lastRenderedPageBreakmarker now serializes onto its ownw:rrather than the text run, breaking the over-specified assertion inissue-830-leading-page-break-roundtrip.test.ts:55.The serialized output is valid OOXML (a standalone marker run is how Word commonly emits it). Relax the assertion to check the marker and the text independently. Test-only change.
Need help on this PR? Tag
/codesmithwith what you need. Autofix is disabled.