Skip to content

fix(release): fail loudly when the Homebrew tap is not updated; verify tap version #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
efij merged 1 commit into from
Sep 2, 2026
Merged

fix(release): fail loudly when the Homebrew tap is not updated; verify tap version #29

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 14 additions & 3 deletions .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -173,7 +173,8 @@ jobs:

# --------------------------------------------------------------- homebrew
# Refreshes efij/homebrew-agentdfir. Needs HOMEBREW_TAP_TOKEN (contents:write
# on the tap repo). Without it the step prints the manual command and passes.
# on the tap repo). Without it the release FAILS visibly: a green release with
# a stale `brew upgrade` is worse than a red one.
homebrew:
needs: verify
runs-on: ubuntu-latest
Expand All @@ -186,7 +187,17 @@ jobs:
run: |
set -euo pipefail
if [ -z "${TAP_TOKEN:-}" ]; then
echo "HOMEBREW_TAP_TOKEN not set. Run locally: scripts/update-tap.sh $RELEASE_TAG"
exit 0
echo "::error::HOMEBREW_TAP_TOKEN secret is not set — Homebrew users would stay on the previous version."
echo "Fix: add a fine-grained PAT with contents:write on efij/homebrew-agentdfir as repo secret HOMEBREW_TAP_TOKEN,"
echo "then re-run this job, or publish by hand: scripts/update-tap.sh $RELEASE_TAG"
exit 1
fi
scripts/update-tap.sh "$RELEASE_TAG"
- name: Verify tap serves this version
run: |
set -euo pipefail
got=$(curl -fsSL "https://raw.githubusercontent.com/efij/homebrew-agentdfir/main/Formula/agentdfir.rb" | grep -o 'tags/v[0-9][0-9.]*' | head -1 | sed 's#tags/##')
if [ "$got" != "$RELEASE_TAG" ]; then
echo "::error::tap formula points at ${got:-nothing}, expected $RELEASE_TAG"; exit 1
fi
echo "tap formula at $RELEASE_TAG"
9 changes: 9 additions & 0 deletions docs/install.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -185,3 +185,12 @@ quarantine flag on macOS and the mark-of-the-web on Windows, before the
release is considered good. The same `verify` job can be re-run at any time
against an already-published tag from the Actions tab (*Run workflow* →
enter the tag), which skips the build and checks only what users download.


## Release checklist (maintainers)

A tag push builds, signs and publishes assets, then updates the Homebrew tap. The tap step **fails the release**
if the `HOMEBREW_TAP_TOKEN` repository secret is missing (fine-grained PAT, `contents: write` on
`efij/homebrew-agentdfir`) and verifies the formula now serves the tag. Manual fallback: `scripts/update-tap.sh vX.Y.Z`.
After every release check all four paths report the new version: `brew upgrade agentdfir`, `install.sh`,
`go install github.com/efij/AgentDFIR/cmd/agentdfir@latest`, raw binary from the releases page.
Loading