fix(release): fail loudly when the Homebrew tap is not updated; verify tap version - #29
Merged
Conversation
…d; verify tap version The tap step silently passed without HOMEBREW_TAP_TOKEN, leaving brew users on the previous version (v0.13.0 shipped while the tap still served v0.12.1; published by hand). Now: missing token fails with a clear fix message, and a verification step asserts the formula serves the released tag.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RCA: release.yml's tap step exited 0 when HOMEBREW_TAP_TOKEN was unset → v0.13.0 released while the tap served v0.12.1 (brew upgrade said 'already installed'). Fixed the tap by hand (scripts/update-tap.sh v0.13.0; brew upgrade now 0.12.1 → 0.13.0, install.sh and go install @latest verified at v0.13.0). This PR: missing token → job fails with the fix; new step verifies the formula serves the tag. Docs: maintainer release checklist. ACTION NEEDED: add repo secret HOMEBREW_TAP_TOKEN (fine-grained PAT, contents:write on efij/homebrew-agentdfir).