Skip to content

feat: ordenar productos por margen de ganancia descendente #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
edwar merged 1 commit into from
Jun 28, 2026
Merged

feat: ordenar productos por margen de ganancia descendente #39

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion app/(protected)/productos/page.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,9 +33,17 @@ export default async function ProductosPage() {
currentStock: Number(ri.supply.currentStock),
minStock: Number(ri.supply.minStock),
purchasePrice: Number(ri.supply.purchasePrice)
} : null
} : null
})) || []

const recipeCost = recipeItems.reduce((acc: number, ri: any) => {
return acc + (Number(ri.quantityRequired) || 0) * (Number(ri.supply?.purchasePrice) || 0)
}, 0)
const unitCost = yieldAmount > 0 ? recipeCost / yieldAmount : 0
const computedMargin = salePrice > 0 && unitCost > 0
? ((salePrice - unitCost) / salePrice) * 100
: profitMargin

let maxBatches = Infinity
if (recipeItems.length === 0) {
maxBatches = 0
Expand Down Expand Up @@ -64,9 +72,12 @@ export default async function ProductosPage() {
companyId: p.companyId,
isPublic: p.isPublic ?? false,
preparation: p.preparation,
computedMargin,
}
})

products.sort((a: any, b: any) => b.computedMargin - a.computedMargin)

const supplies = suppliesRaw.map((s: any) => ({
id: s.id,
name: s.name,
Expand Down
11 changes: 11 additions & 0 deletions app/api/products/route.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,14 @@ export async function GET() {
} : null
})) || []

const recipeCost = recipeItems.reduce((acc: number, ri: any) => {
return acc + (Number(ri.quantityRequired) || 0) * (Number(ri.supply?.purchasePrice) || 0)
}, 0)
const unitCost = yieldAmount > 0 ? recipeCost / yieldAmount : 0
const computedMargin = salePrice > 0 && unitCost > 0
? ((salePrice - unitCost) / salePrice) * 100
: profitMargin

let maxBatches = Infinity
if (recipeItems.length === 0) {
maxBatches = 0
Expand Down Expand Up @@ -66,9 +74,12 @@ export async function GET() {
maxPossibleBatches: maxBatches === Infinity ? 0 : maxBatches,
isPublic: p.isPublic ?? false,
preparation: p.preparation,
computedMargin,
}
})

mapped.sort((a: any, b: any) => b.computedMargin - a.computedMargin)

return NextResponse.json(mapped)
} catch (error) {
console.error('Error fetching products:', error)
Expand Down
2 changes: 1 addition & 1 deletion app/tienda/[slug]/producto/[productId]/producto-detalle-client.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -177,7 +177,7 @@ export function ProductoDetalleClient({ product, company }: { product: Product;
{product.ingredients.map((ig, i) => (
<div key={i} className="flex items-center gap-2 p-2.5 rounded-lg bg-accent/20">
<Check className="w-3.5 h-3.5 text-emerald-500 shrink-0" />
<span className="text-sm">{ig.name}<span className="text-muted-foreground ml-1">({ig.quantity} {ig.unit})</span></span>
<span className="text-sm">{ig.name}</span>
</div>
))}
</div>
Expand Down
Loading