fix: pin electron to 41.x so release builds produce installers#119
Merged
Conversation
The v0.0.20 release failed — macOS build jobs succeeded but emitted no .dmg/.zip, so Create Release errored on missing artifacts. The only change since the last good release (v0.0.19, on electron 41) was the electron 42.x bump (#115, then #116 → 42.3.3); ci.yml never runs `electron-forge make`, so it surfaced only at release time. Pin electron back to ^41.7.1 (keeping the other #116 dependency updates). Verified locally: `electron-forge make --arch=arm64` on electron 41.7.1 produces out/make/PapaStudio.dmg and the arm64 zip. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
eboudrant
force-pushed
the
fix/pin-electron-41
branch
from
6f9b93c to
e8de649
Compare
eboudrant
added a commit
that referenced
this pull request
Jun 5, 2026
The v0.0.20 release produced no installers: electron-forge 7.11.2 (latest stable) silently fails to run the makers under Node 24.x — `make` stops after packaging and emits no .dmg/.zip. Reproduced locally: Node 24 → nothing, Node 22 → dmg + zip. electron was never the cause (v0.0.19 shipped on 42.2.0), so this also reverts the misdiagnosed #119 pin back to ^42. - release.yml: build job Node 24 → 22. - package.json: electron ^41.7.1 → ^42.0.0 (resolves 42.3.3). Verified locally: npm ci + electron-forge make on Node 22 + electron 42.3.3 produces PapaStudio.dmg and the arm64 zip. Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The v0.0.20 release failed: the macOS build jobs reported success but produced no
.dmg/.zip, so the "Create Release" job errored downloading the missingpapastudio-arm64/papastudio-x64artifacts.Root cause: the only change since the last good release (v0.0.19, built on electron 41) was the electron → 42.3.0 bump in #115.
ci.ymlnever runselectron-forge make, so the packaging regression slipped through and only surfaced at release time. This pinselectronback to ^41.7.1 (resolves 41.7.1), restoring the known-good packaging path.Test plan
npx electron-forge make --arch=arm64locally on electron 41.7.1 produces bothout/make/PapaStudio.dmgand the arm64 zip. (The "Making for the following targets: ," log line is a cosmetic electron-forge display quirk — the makers do run and emit installers.)Releaseworkflow for v0.0.20.🤖 Generated with Claude Code