ci: pin release build to Node 22; restore electron to ^42#121
Merged
Conversation
The v0.0.20 release produced no installers: electron-forge 7.11.2 (latest stable) silently fails to run the makers under Node 24.x — `make` stops after packaging and emits no .dmg/.zip. Reproduced locally: Node 24 → nothing, Node 22 → dmg + zip. electron was never the cause (v0.0.19 shipped on 42.2.0), so this also reverts the misdiagnosed #119 pin back to ^42. - release.yml: build job Node 24 → 22. - package.json: electron ^41.7.1 → ^42.0.0 (resolves 42.3.3). Verified locally: npm ci + electron-forge make on Node 22 + electron 42.3.3 produces PapaStudio.dmg and the arm64 zip. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This was referenced Jun 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the broken v0.0.20 release (it produced no installers).
Root cause (reproduced locally both ways): electron-forge 7.11.2 — the latest stable — silently fails under Node 24.x.
electron-forge makeruns the package phase, stops at "Finalizing package", never runs the dmg/zip makers, and exits 0 with an emptyout/make. On Node 22, the same code + deps produce the dmg + zip.ci.ymlnever runsmake, so it only surfaced at release time.electron was not the cause — v0.0.19 shipped on electron 42.2.0, and both 41 and 42 build fine on Node 22 / fail on Node 24. So this also reverts the misdiagnosed #119 electron pin back to
^42.No stable electron-forge supports Node 24 yet (only
8.0.0-alphatargets it), so pinning the release build to Node 22 is the robust fix.Changes
release.yml: build jobsetup-node'24'→'22'(with an explanatory comment).package.json:electron^41.7.1→^42.0.0(resolves 42.3.3).Test plan
npm ci+npx electron-forge make --arch=arm64on Node 22 + electron 42.3.3 runs both makers and emitsout/make/PapaStudio.dmg+ the arm64 zip. On Node 24 the same setup emits nothing.Releaseworkflow for v0.0.20.🤖 Generated with Claude Code