Repository navigation
fix: fold demo learnings (strict-mode F&O error text, delete_groups measured, show-in-menu column) (5.8.6) - #177
Merged
Conversation
…easured, show-in-menu column) (5.8.6) Get-FoErrorText no longer throws under strict mode on a 404 with no body. canonical-setup-order.md states the measured delete_groups result and the create_products echo. cheat-sheet.md names the column save_pages showInMenu writes, from the add-in source.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three demo-skill fixes from learning triage.
Get-FoErrorTextreadErrorDetails.Messagewith no null check. UnderSet-StrictMode -Version Latesta 404 with no body threw inside the caller's catch block, soImport-GoldenPackage.ps1stopped before it created a missing import project. It now handles every error shape and falls back to the body text or the exception message. New hermetic suitetests/Fo.Api.Tests.ps1(9 cases; 4 failed on the old code, all pass now).canonical-setup-order.md:delete_groupsmeasured on DW 10.28.12 with MCP 0.6.0. It deletes no products (one group or two), and it leaves the group's product relations and shop relation as orphans that a same-id group picks up. Step 10 says to readstockStatusback, because the create response echoesneverOutOfStockwrongly.cheat-sheet.md:save_pages {showInMenu:false}writesPageActive, likeset_page_menu. In the 0.6.0 and 0.6.1 add-in source,PageCreateModelandPageMenuModelboth mapShowInMenutoPage.Active, and no tool writesPageShowInLegend.Validation:
python3 scripts/validate-skills.pygives 0 errors.node scripts/build-manifest.mjswas run.Invoke-Pester tests/Fo.Api.Tests.ps1gives 9 passed.