Repository navigation
fix(dw-render-viewmodels): the no-picture fallback hides a null DefaultImage (5.8.7) - #178
Merged
Merged
Conversation
Justinvolved
changed the base branch from
fix/lrn-triage-demo-2026-10-02
to
main
October 2, 2026 13:07
…ltImage (5.8.7) A crash reproduction or a sweep proof must blank Ecom/Picture/NoPicture for the run; the fallback also covers unguarded templates until they are fixed.
Justinvolved
force-pushed
the
fix/lrn-defaultimage-nopicture
branch
from
October 2, 2026 13:07
af70343 to
41bbd83
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #177 (it shares CHANGELOG.md and marketplace.json). Retarget to main after #177 merges.
viewmodel-traps.md§1 states whenproduct.DefaultImageis really null. WhenEcom/Picture/NoPicture(Large,Large_path) is set, DW fillsDefaultImagewith the fallback image for a product with no image and no assets. An unguarded template then renders a clean page. So:Swift-v2_ProductMedia.cshtmlgave a clean PDP for a zero-asset product. With the fallback blank, the same PDP rendered aNullReferenceExceptionblock at HTTP 200.Validation:
python3 scripts/validate-skills.pygives 0 errors.node scripts/build-manifest.mjswas run.