Repository navigation
Ship Workflow compatibility fix in Server 2.5.6 - #308
Merged
Merged
Conversation
rmcdaniel
marked this pull request as ready for review
October 6, 2026 23:44
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Server 2.5.6
Rebuild the pinned Server consumer with published Workflow 2.4.6 for durable-workflow/workflow#636.
The fix keeps an explicitly supplied run authoritative when its compatibility marker is null. It avoids an unnecessary relationship lookup and the resulting Laravel lazy-loading violation. Task-marker precedence and the omitted-run fallback are preserved.
No schema or portable worker protocol change is involved. Qualify the source, publish both architectures, verify the embedded package identity and run the exact published PHP/Python/Rust lifecycle matrix before calling the Server consumer delivered. Cloud deployment qualification remains separate.
The initial source run passed 2,546 of 2,547 cases. The remaining failure read a calendar-minute rejection counter after requests made on the live clock. This PR freezes time for that existing quota test, preserving its exact assertions and production counter behavior. The normal checks rerun on the corrected head.