TaskCompatibility::resolve() lazy-loads $task->run when the passed run has no compatibility marker

[vanducng]

TaskCompatibility::resolve() loads $task->run even when the caller has already passed that run, provided the run's compatibility is null:

// src/V2/Support/TaskCompatibility.php:15
return self::normalize($task->compatibility)
    ?? self::normalize($run?->compatibility ?? $task->run?->compatibility);

When $run is given and $run->compatibility is null, the inner ?? falls through to $task->run. Every app that sets no worker-compatibility marker hits this path, because both the task and the run carry null.

Effect

RunSummaryProjector::taskWaitingForCompatibleWorker($task, $run) passes the run explicitly. It runs inside the history projection on every task dispatch, activity outcome, timer and watchdog pass. Each call then costs one extra workflow_runs query per task. In an app with Model::preventLazyLoading() enabled outside production, each call also logs or throws a lazy-loading violation for WorkflowTask::run. One short workflow run produced about 60 of them.

Reproduction

1. Leave workflows.v2.compatibility.current unset (the default).
2. Load a WorkflowTask fresh from the database, so the run relation is not loaded.
3. Call TaskCompatibility::resolve($task, $task->run()->first()).
4. $task->relationLoaded('run') is now true, and a second workflow_runs query ran.

Present on main (baf795ce) and in 2.4.5.

Suggested fix

Use the passed run when there is one, and fall back to the relation only when no run is passed:

?? self::normalize($run !== null ? $run->compatibility : $task->run?->compatibility);

I'll open a PR with this change and a regression test.

[rmcdaniel]

Fixed and published in Native 2.4.6 and Server 2.5.6.

An explicitly supplied run is now authoritative even when its compatibility marker is null. Task marker precedence and the omitted-run relationship fallback are preserved. Thank you @vanducng for the fix in #637.

Verification is complete:

• Full Native source gates and the 16-cell published Laravel/PHP upgrade matrix pass.
• A fresh Composer-installed consumer passes nine regression cases with 24 assertions, including zero-query resolve/sync checks and real workflow/activity handlers under Laravel's lazy-loading guard.
• Server's 2,547 feature tests and all affected source gates pass. Both published architectures, both registries, first-run readiness, source-free Compose startup and Helm 0.1.143's anonymous clean install pass.
• The exact published Server lifecycle qualification passes all 12 PHP/Python/Rust lifecycle cells with no findings.
• Waterline's development-only consumer update is merged in Test embedded Waterline with Workflow 2.4.6 waterline#144 with all checks passing. No Waterline runtime release is needed.
• Sample App's locks and tuple are updated in Adopt published Workflow 2.4.6 compatibility fix sample-app#145. All source and polyglot checks pass, along with both architectures of its actual published development image.
• Website update Refresh stable releases for compatibility fix durable-workflow.github.io#165 is deployed. The public stable-release manifest exactly matches source.

The Server image index is sha256:1d1d42cee3e6d4536effc3243e63d56c989578b97b09d5c346e882d3470091f8. Its package provenance identifies Native 2.4.6 at 551fe0ae6908f59a2b0efe51b2f04e32719bd0a1.

Closing after published consumer verification.