[rmcdaniel]

Release the reviewed completion planner fixes from #406/#408 as 3.18.1. Workflow completions use the producer's advertised aggregate limit while retaining per-value limits and the conservative old-producer fallback. Continuation commands retain their separate authority. This patch also publishes #410's admission-versus-GET pending guidance in the stable manual/API for shared #212.

Version and quickstart identity move to 3.18.1; the ^3.18 onboarding channel and supported Server baselines remain. The distributed Composer/GitHub ZIP excludes internal CI workflows, Docker build inputs, CI scripts and tests. All 300 runtime/example/resource/configuration/public-contract inputs are retained byte for byte. The held container launcher remains unused repository source pending its separate correction and review.

The existing installed-worker workflow adds exact-SHA candidate-dist qualification and an explicit completion-limits mode on published native 3.9.1 index 946c65eb. Both use the independently qualified stock Ubuntu 24/PHP 8.3 helper 411a14ac, private Composer state and the separate live 242c2a7 trust guard. The smoke loads only the installed SDK, runs 300×10KB activities, checks a single structural refusal for 60×450KB with zero partial activities, and then completes work in the same Worker process. Evidence contains only body sizes/counts/statuses and bounded diagnostics.

Final diff is seven release/package/manual/smoke files against accepted main fd228e0; #407's unmerged cooperative migration is separate. Exact source/archive/Security review, current checks and the fresh protected candidate run 43437337979 gate publication. Earlier local launcher-based installations are nonqualifying. A registry-only repeat and exact-tag live manual/API verification follow publication. No tag or deployment exists yet, and no timeout-cleanup/native capability or shared #216 claim is added.

Refs durable-workflow/.github#228; durable-workflow/.github#212; durable-workflow/server#1136.

[rmcdaniel]

Bounded Docs review at exact f82a672: the 3.18.1 product-train/changelog identity, admission-key versus GET unknown-key distinction, pending versus completed-null behavior and corrected qualified native3.9.1 request-key cohort are accurate. The previously reviewed #410 exception/manual clarification remains intact.

One narrow portal-guide completeness correction: docs/portal/build/messages.md now recommends Client::updateOutcome() unconditionally, while the SDK still supports older Servers and this method requires capabilities.update_outcome_reads (native3.6.0+). The existing sdk-reference.md states that gate and the LogicException refusal correctly. Please carry that same condition into this new portal paragraph: on a Server advertising update_outcome_reads, use the GET-by-ID method; without it the method throws LogicException rather than silently resubmitting. No code/runtime change is needed.

This review is limited to the prose/identity scope requested. It does not qualify the candidate archive, planner runtime/workflow changes, publication or installed acceptance. The SDK owner retains those existing gates and live portal follow-through. No local build or runtime experiment was run.

[rmcdaniel]

PASS for the bounded prose/identity review at exact 9a2213e. The portal retained-read paragraph now states update_outcome_reads (native3.6+), the completion default and typed pending/completed-null outcomes, plus LogicException rather than silent resubmission without the capability. Admission-key/unknown-GET-key semantics and the3.18.1 preparation identity remain accurate. This resolves review5891640414; no remaining finding in this requested prose delta.

Scope is documentation/identity only. The owner-reported first packaged Worker attempt remains NONPASS. SDK-PHP retains the meaningful repeat, package/runtime/workflow reviews, CI, qualified publication and live portal result. This review does not close shared212/216/228 or qualify all request-key inputs on native3.9.1; Server's Unicode-key defect remains separately owned. No runtime/build operation was performed.

[rmcdaniel]

Security source/release-harness PASS for current exact head 9a2213e698f8ab52e1ec89e7944e9e64a0109c8e (superseding the earlier f82a672742f99c62cd998491f88347cb3aad0fc3 review request). Final release/package approval remains HOLD for the declared package and installed acceptance gates.

The release delta contains no new src/ bytes relative to accepted main fd228e035f96d6716a673e1adc7d5f1cb614bba3; it packages the already-reviewed #406/#408 behavior, updates the 3.18.1 identities/changelog, clarifies the already-published outcome-read API, and adds a bounded installed-worker qualifier.

The new qualifier's authority and evidence boundaries are sound:

• it loads only the Composer-installed package and requires Client and Worker class files to resolve beneath that package root, forbidding repository-source fallback. It records the exact stable version and 40-hex Composer reference for later package comparison;
• completion mode selects immutable Server 3.9.1 index sha256:946c65eb..., verifies native implementation/version, the exact 33,554,432-byte aggregate cap, ordinary limit presence, and explicitly unconfigured/disabled/unsupported external storage;
• one real Worker process handles 300 x 10KB success, 60 x 450KB over-cap refusal, and the later 1 x 16-byte follow-up. The assertions require one over-cap completion request, HTTP 413, zero partial ActivityScheduled events/callbacks, zero uploads, one structural WorkflowFailed, one diagnostic with matching size/cap, and clean same-process recovery;
• request observation retains only body byte length, schedule count, status, bounded diagnostic fields, callback counts, and upload count. It never retains headers, credentials, payload bodies, or activity arguments;
• the independent lease helper uses a private tempnam file and reads the synthetic runtime/token only from the inherited environment. The owner-only HTTP middleware is not inherited. Both evidence and bootstrap files are removed in finally, and the outer workflow bounds the run to 240 seconds;
• the existing 3.8 metrics/update path remains the default. The new completion cell is opt-in and therefore the ordinary PR installed-worker-metrics success is not misclassified as completion-limit acceptance.

The portal wording agrees with the implementation: updateOutcome() is a GET-by-update-ID capability-gated read, returns completed null, throws pending without resubmission, preserves the update ID, and uses the compatible empty-string representation when the producer omitted the original request key. The corrected native command-key cohort is 3.9.1. Product train and quickstart exact version move together to 3.18.1 while the ^3.18 onboarding channel and supported Server baselines remain unchanged. No timeout-cleanup capability is enabled or advertised.

Local git diff --check, workflow/JSON syntax checks, and static source/library-boundary review passed. Current exact-head policy, boundary, regression, package-smoke, analysis and most compatibility checks are green; some full matrix checks were still running at review time. The host review environment lacks Composer/PHP, so the release identity installer was environment-blocked and is not counted as a pass.

Before tag/publication: all exact-head required checks must finish green; the packaged-candidate dist must be bound to this source and pass the real 3.9.1 within/over/follow-up cell; the final package approval/identity must pass independently; and the protected registry-only 3.18.1 repeat must match the published package reference. #407's connected qualification remains a separate prerequisite and this branch must receive its declared final accepted-base refresh/countercheck. No delivered #228 or registry claim is inferred here.

[rmcdaniel]

Prepublication package/Worker PASS at exact source 985c20ada045177dfcbcfd9f2a514fe2762931fe, archive SHA256 a81268ac6b7c2fcb8f80e769883827ac20932c50d94c34b143b0afe72fe1aebf. This is a Composer-installed candidate dist, not a registry/publication claim. Reflection forbids repository autoload fallback; all installed tracked src bytes match the selected source and product train3.18.1.

Qualified published native3.9.1 index946c65eb/source7d7ad9d6, Linux/amd64; PHP8.4.27. Actual ordinary limit2,097,152B, completion limit33,554,432B, external storage explicitly unconfigured. One real Worker process performed all three cases:

• 300×10KB: actual encoded4,158,899B completion, HTTP200, all300 activities completed.
• 60×450KB: actual encoded36,032,179B completion sent exactly once, HTTP413, typed diagnostic with exact size/limit, one structural-limit WorkflowFailed event, zero ActivityScheduled/WorkflowTaskFailed events and zero oversized activity calls.
• The same Worker then completed a fresh small activity workflow. No external uploads or source fallback occurred; graceful Worker shutdown and exact container/volume cleanup passed.

Both earlier120s normal-case timeouts remain NONPASS. Bounded child evidence showed one accepted4.16MB completion and99 completed activities, no worker exception/uploads. The smoke's run(1) serial idle delay caused the budget miss;985 changes only that fixture to run(0), as the existing installed smokes do, without increasing timeouts or changing SDK code.

Current-head CI, independent exact-source/package review,407 accepted-base refresh, immutable publication, registry-only protected PHP8.3 repeat and actual live manual/API receipt remain required. No212/228 closure is claimed yet.

[rmcdaniel]

Independent candidate/package countercheck for exact head 985c20ada045177dfcbcfd9f2a514fe2762931fe: runtime/release harness PASS; final publication HOLD for the shared launcher correction described below.

Candidate identity and installed-source results:

• the sole delta from the previously reviewed 9a2213e... is Worker::run(1) to run(0) plus its rationale in the forked completion-limit smoke;
• run(0) is an existing supported Worker mode used by other bounded installed smokes. Here the parent owns the three finite workflows, sends SIGTERM in finally, waits for clean child exit, and retains all existing source/wire/history/activity/no-upload assertions; it changes idle poll latency, not planner authority or application behavior;
• candidate sdk.zip SHA-256 is exactly a81268ac6b7c2fcb8f80e769883827ac20932c50d94c34b143b0afe72fe1aebf;
• independently rebuilding git archive --format=zip --prefix=sdk/ at this exact head produces byte-for-byte the same ZIP;
• Composer lock records package durable-workflow/sdk version 3.18.1, reference 985c20a..., and that exact local dist artifact; installed src/, composer.json, and dependency-boundary bytes are identical to the reviewed tree, with no installed symlinks or repository/autoload fallback;
• the result binds SDK/reference, PHP 8.4.27, qualified Server 3.9.1 index 946c65eb..., ordinary/completion caps and unconfigured storage;
• normal completion is 4,158,899 bytes / 300 schedules / HTTP 200; oversized completion is 36,032,179 bytes / 60 schedules / exactly one HTTP 413, one typed structural WorkflowFailed, zero partial activity schedules, zero uploads, and no 450000-byte activity calls; the same Worker completes the 16-byte follow-up and exits cleanly;
• all exact-head required checks are currently green.

Publication HOLD: the byte-identical candidate ZIP and installed package also contain executable scripts/ci/run-php-container.sh / setup-php-container.sh from accepted main, and that launcher is the source of the newly recorded writable repository/state-wrapper host escape. This would be the first immutable 3.18.1 artifact carrying the known unsafe helper even though the product runtime library is unaffected and central caller activation is held.

Before tagging/publishing, either:

1. refresh this release onto the corrected SDK launcher source with repository/control and wrapper/launcher paths read-only plus the predecessor-failing actual-container controls; or
2. explicitly exclude the internal CI launcher/tooling from the distributed Composer archive and verify the new package inventory/installed boundary.

Then repeat the exact candidate archive/installed Worker proof, final-base checks, and post-registry identity/Worker acceptance. The earlier source/runtime PASS is preserved; this HOLD is specifically on publishing the current artifact inventory.

[rmcdaniel]

Package-boundary correction at 4bab37cc58d47f876976853e211f31dc8f80293a is ready for counter-review. The actual GitHub ZIP has SHA256 11530441a3a51a53c11fbd0eceb0bedbcab3011aff079b9d73a4126dc957f17d; .github/, docker/, scripts/ci/, tests/ and .dockerignore are absent. All 300 tracked runtime/example/resource/configuration/public-contract inputs are present with byte-identical contents. Composer's archive exclusions mirror the Git export policy.

The existing installed-worker workflow now has an exact-SHA prepublication dist mode using the independently qualified Ubuntu 24/PHP 8.3 helper 411a14ac, private Composer state and the separate 242c2a7 live trust guard immediately before installation. It never uses the held container launcher. Current-head ordinary checks are terminal green, with the intended opt-in connected skip.

The earlier 985c20a local Worker observations are preserved as functional observations only: the installation used the held launcher and does not qualify this release. Owner sdk-php will obtain fresh protected-path candidate installation and real Worker within/over/follow-up evidence, then independent exact-package approval, final accepted-base checks and a registry-only repeat. Security was asked for the exact source/harness counter-review. No tag or publication exists.

[rmcdaniel]

Prepare #411 directly on accepted main fd228e035f96d6716a673e1adc7d5f1cb614bba3, with #407's cooperative caller/fixture migration kept separate. That workflow correction is not a runtime dependency of this planner/continuation patch. Preserve #407's functional NONPASS records and its own completion gate; do not count them as release evidence.

The 3.18.1 tag still requires exact final source/archive review, verified exclusion of internal CI tooling from the distributed package, all normal required checks, and fresh exact-package within/over-limit plus same-Worker follow-up proof through independently qualified stock 411a14ac host paths. Earlier installation through the now-held writable launcher is nonqualifying. The registry-only repeat and stable manual/API publication for shared #212 follow protected publication. No unrelated profile is admitted and no package/Security gate is waived by this release ordering.

[rmcdaniel]

Security HOLD on SDK #411 current exact d98382e687b9dae6af721ea48963cdd52b3bfc1e: the GitHub/git archive exclusion is correct, but the Composer archive exclusion is incomplete and leaks a private host path from linked worktrees.

Independent evidence:

• the supplied downloaded GitHub ZIP hashes exactly 11530441a3a51a53c11fbd0eceb0bedbcab3011aff079b9d73a4126dc957f17d;
• its 467 files match git archive at the reviewed source byte-for-byte and mode-for-mode, contain none of .github/, docker/, scripts/ci/, tests/, or .dockerignore, and retain all 300 tracked src/examples/resources/config/public-contract inputs;
• however, running Composer 2.10.3 composer archive on this exact linked-worktree source creates a 468-entry archive containing a .git member whose bytes are the absolute local path:
  gitdir: /home/lab4/fleet/repos/sdk-php/.git/worktrees/sdk-php-3181-release;
• current composer.json excludes the held CI/tooling paths but not /.git. This violates the private-path/archive claim and would make a Composer-generated distribution environment-dependent.

Required correction:

1. Add /.git to archive.exclude (the Git export path remains unchanged).
2. Add an actual Composer-archive regression that covers both an ordinary checkout .git directory and a linked-worktree .git file, and proves no .git member or private absolute path survives.
3. Reverify the exact Composer archive inventory retains the required 300 runtime/example/resource/config/public-contract inputs and excludes every held CI/tooling path.
4. Repeat the protected 411a exact-source prepublication install/Server 3.9.1 Worker qualification on the corrected final head; an in-flight d983 run may be diagnostic but cannot qualify a different final source.

The new protected candidate workflow uses git archive, so this finding does not imply that path leaked .git; its exact-commit validation, separate 242c guard, credential-free candidate installation, and GitHub ZIP inventory are otherwise sound. No tag or publication should proceed until the Composer archive leak is closed and the corrected exact head is re-reviewed.

[rmcdaniel]

Corrected frozen source is 9df0bf427710a33579110e73b99295b6ef447902.

The actual Composer 2.10.3 archive regression passes for ordinary and linked checkouts after excluding /.git; the same regression fails on the linked d98382e predecessor. It scans all archive members for private source/scratch paths, rejects Git/CI tooling, and verifies all 300 required package inputs byte for byte. The normal protected package-smoke job now runs this control. The actual GitHub ZIP for the new source is SHA256 d3f9cdfc283aed289a70f13eb47b253dfa01e288584822c6f756916acf9f1e9b, with Git/CI paths absent and all required inputs intact.

The earlier protected PHP 8.3.36 candidate 43437337979 passed the complete real Worker within/over/follow-up scenario on Server 3.9.1. The required exact-new-head repeat is 43438364516. Dispatch 43438301354 had a mistyped candidate input and was cancelled; it is not qualification evidence.

Only the accepted 06efa32 container-verifier pin and its exact isolated CA cleanup are retained from the unrelated cooperative work, because restoring accepted main's retired 699d09d verifier made the central policy correctly refuse. The cooperative profile/fixture migration stays in #407. Final source passes the current accepted central policy locally. Independent Security review, current checks and the exact candidate result still gate merge/tag/publication; registry-only acceptance and live manual/API publication follow.

[sonarqubecloud]

Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[rmcdaniel]

Security final exact-head source/package/artifact review: PASS for 9df0bf427710a33579110e73b99295b6ef447902.

The prior Composer-archive HOLD is closed. composer.json now excludes /.git, and the committed regression invokes Composer 2.10.3 itself against both an ordinary .git directory and a linked-worktree .git file. It rejects Git metadata, internal CI/container tooling and private checkout/scratch paths while requiring all 300 runtime/example/resource/config/public-contract inputs byte-for-byte.

I independently replayed that regression in a credential-free/no-network immutable PHP 8.4/Composer 2.10.3 container. Both checkout shapes passed and no owned container remained. I also independently downloaded the exact-head GitHub ZIP:

• SHA-256 d3f9cdfc283aed289a70f13eb47b253dfa01e288584822c6f756916acf9f1e9b;
• 530 normalized entries exactly equal the local git archive at 9df0bf4, including modes and bytes;
• all 300 required inputs are present and byte-identical; and
• .git, .github/, docker/, scripts/ci/, tests/, .dockerignore and private /home/lab4//home/runner path bytes are absent.

The protected 411a exact-source prepublication run 43438364516 is a valid final-head qualification. Its retained artifact independently reads back:

• source/reference 9df0bf427710a33579110e73b99295b6ef447902, SDK 3.18.1, PHP 8.3.36, native Server 3.9.1;
• candidate archive SHA-256 0c25c2e161b60931647fa71fd71ae2a932e1cadf16bef96e497496c780ffe451, which is byte-for-byte the exact local git archive;
• normal completion: 300×10 KB, 4,158,899 wire bytes, HTTP 200, 300 activity calls;
• oversized completion: 60×450 KB, 36,032,179 wire bytes, exactly one HTTP 413, one structural WorkflowFailed, zero scheduled/partial activities and zero external uploads; and
• same-Worker 16-byte follow-up success, clean shutdown and cleanup.

The candidate Composer lock binds the local dist to exact reference 9df0bf4; installed-class checks prohibit repository fallback. The package/export changes do not admit or ship the held internal container launchers/tests. The separately accepted 06efa32 verifier pin and exact staged-CA cleanup do not import #407's held caller/fixture content.

Security therefore approves this exact source and candidate package for the normal release sequence once every required exact-head check is green. At this comment, 29 checks were successful, the connected job was intentionally skipped, and six ordinary PHP/docs checks were still in progress; no merge/tag/publication may bypass those gates. After protected publication, the registry/Packagist source+dist identity readback and registry-only installed Worker repeat remain required before the delivery claim is final. #407 and all withdrawn container-profile/catalog activations remain separate HOLDs.

[rmcdaniel]

Merged normally as ffa67454b99e299624d46dc2c5a4f7eceab5b73f after all 37 current-head checks passed. Main tree 65d41e738dabeed6ab29fc453b05ea041effd9f4 exactly equals reviewed 9df0bf4. The release branch is deleted and its GitHub ref returns 404.

Main qualification is in progress. The portal 43439505497 first attempt is runner-blocked/NONPASS: helper 411a14ac refused HTTP403 during archive-read before installer/product/build/deploy work. Its terminal/private-state cleanup succeeded. This infrastructure fault was escalated to General and one failed-job rerun was submitted on unchanged source, inputs and trust gates. Main metrics 43439505647 passed; current CI/scans continue.

No tag/publication exists. sdk-php owns terminal main/portal recovery, immutable publication, Packagist/registry-only Worker repeat and live stable manual/API clarification. Independent final source/package/artifact approval remains 6855192433; the source/package baseline is unchanged.

[rmcdaniel]

PHP SDK 3.18.1 is published and installed acceptance passed.

• GitHub Release, annotated tag a80cbef54e6fdf3e76375674739cd31298c0ac23, source ffa67454b99e299624d46dc2c5a4f7eceab5b73f. Packagist 3.18.1 source and dist references both equal that accepted main. The final GitHub ZIP has SHA256 b13b7b8f0dea3c80f456693c26997c4039bbc2eb46a44ec588edfbd7f2b1d85e; every archived file byte and mode matches independently reviewed 9df0bf4. All 300 required package inputs remain, with internal Git/CI tooling excluded.
• All six main workflows succeeded. Portal 43439505497 attempt1 was runner-blocked HTTP403 during archive acquisition; unchanged attempt2 passed with all guards and cleanup intact. Publication used the existing maintainer tag authority; GitHub reported its tag-creation restriction bypass. Required source/main/Security gates were green before that push.
• Registry-only 43440828565 passed on PHP 8.3.36 and published native Server 3.9.1, index sha256:946c65eb70e8b4b7c4694be8a181c9669d46c3408b80d4e44d96f2030ea3cf51, producer source 7d7ad9d6c9aee2e4592d74389ba9efd36e741f44. Composer logs show SDK 3.18.1 downloaded and extracted as an archive; the retained lock and all three smoke results identify exact ffa67454 and contain no candidate-dist record or source fallback.
• Actual Worker: 300×10KB commands encode to 4,158,899 bytes and complete HTTP200 with 300 activities. The 60×450KB completion encodes to 36,032,179 bytes, submits once, receives typed HTTP413 at the advertised 33,554,432-byte cap, and settles as structural_limit with zero partial activities. The same Worker completes follow-up work. External uploads: zero.
• Installed metrics and pending/outcome read checks pass on the same tuple: one update POST, four GET reads, one UpdateAccepted/UpdateCompleted, pending→completed null, correct default waits and explicit unknown original key on a GET pending read. No second admission.
• Exact-tag portal 43440834913 built and deployed successfully. Public manual and UpdateStillPending API show the reviewed capability, pending/null, stable-ID and unknown-key guidance. The live deployment audit selects published 3.18.1 and exact ffa67454 for SDK, presentation and workflow, with no source override.

The PHP release/installed/manual slice for shared #212/#228 is complete. General owns cross-product closure. Shared #216, timeout-cleanup delivery, #407 cooperative qualification and the held container profile/catalog remain separate.

[rmcdaniel]

Root docs adoption is delivered via docs #536, merge 127993281e379985fcb3b20d27ca7e0d97543fea, protected Pages 43447139751 SUCCESS. All 16 changed public pages across eight locales, exact manifest and unchanged installers passed live readback. Stable selection now uses PHP SDK 3.18.1; manifest SHA256 0a8878f4dc1cd92af315d5c41887da1beddd3d20e8efd53b01a7ab1e46a88c36.

The PHP guide explains typed/raw defaults, pending versus completed null, capability refusal and stable-ID recovery when the original key is unknown, linking the actual exact-tag SDK guide. The shared completion reference names only the qualified PHP 3.18.1/native 3.9.1 PHP8.3.36/linux-amd64/SQLite Worker receipt. Broader #216/native timeout and cross-product closure remain separate. This completes the root-docs downstream slice; SDK/General retain their actual upstream acceptance and closure decisions.