Update the onboarding password import result row icons and sizing - #9686
Merged
catalinradoiu merged 2 commits intoSep 7, 2026
Merged
Conversation
catalinradoiu
requested review from
malmstein and
mikescamell
as code owners
September 2, 2026 11:40
This was referenced Sep 2, 2026
Contributor
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
4 tasks
Base automatically changed from
feature/cradoiu/onboarding-password-import-flow
to
develop
September 3, 2026 16:15
…in the onboarding import flow
Use bold-spanned counts and updated recolorable icons in the import complete card, and add a missing period to the password import body copy. Asana: https://app.asana.com/1/137249556945/project/1211724162604201/task/1218143516747353
catalinradoiu
force-pushed
the
fix/cradoiu/onboarding-import-update-assets
branch
from
September 7, 2026 10:51
b068fa4 to
cd2b346
Compare
catalinradoiu
deleted the
fix/cradoiu/onboarding-import-update-assets
branch
September 7, 2026 13:05
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Task/Issue URL: https://app.asana.com/1/137249556945/project/1211724162604201/task/1218143516747353
Tech Design URL (if applicable):
API Proposals URL(s) (if applicable):
Description
Address ship review feedback on the onboarding password import flow:
Steps to test this PR
QA-optional (check attached screenshots)
UI changes
Note
Low Risk
Onboarding UI and copy only; no auth, data, or import logic changes.
Overview
Polishes the pre-onboarding password import complete screen so each outcome row has a distinct status icon and slightly larger row artwork.
Imported rows now use a green check (
check_recolorable_24), skipped rows keep the gray cross, and failed rows use a red cross (cross_recolorable_24) instead of the gray icon on every row. Shared result row layout icon size increases from 20dp to 24dp.Imported and skipped counts are formatted as strings and passed through
applyBoldSpanToso the numeric values stand out; related copy strings switch from%1$dto%1$s. A trailing period is added to the import-passwords body string.Reviewed by Cursor Bugbot for commit cd2b346. Bugbot is set up for automated code reviews on this repo. Configure here.