Skip to content

Update the onboarding password import result row icons and sizing - #9686

Merged
catalinradoiu merged 2 commits into
developfrom
fix/cradoiu/onboarding-import-update-assets
Sep 7, 2026
Merged

catalinradoiu merged 2 commits into
developfrom
fix/cradoiu/onboarding-import-update-assets

Conversation

@catalinradoiu

@catalinradoiu catalinradoiu commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

Task/Issue URL: https://app.asana.com/1/137249556945/project/1211724162604201/task/1218143516747353
Tech Design URL (if applicable):
API Proposals URL(s) (if applicable):

Description

Address ship review feedback on the onboarding password import flow:

  • Bold the imported/skipped counts in the import complete card
  • Update icons size
  • Add in the recolorable check/cross icons for the imported and failed rows
  • Add a missing period to the import passwords body copy

Steps to test this PR

QA-optional (check attached screenshots)

UI changes

Import success Import error
Screenshot 2026-09-07 at 15 50 27 Screenshot 2026-09-07 at 15 53 44

Note

Low Risk
Onboarding UI and copy only; no auth, data, or import logic changes.

Overview
Polishes the pre-onboarding password import complete screen so each outcome row has a distinct status icon and slightly larger row artwork.

Imported rows now use a green check (check_recolorable_24), skipped rows keep the gray cross, and failed rows use a red cross (cross_recolorable_24) instead of the gray icon on every row. Shared result row layout icon size increases from 20dp to 24dp.

Imported and skipped counts are formatted as strings and passed through applyBoldSpanTo so the numeric values stand out; related copy strings switch from %1$d to %1$s. A trailing period is added to the import-passwords body string.

Reviewed by Cursor Bugbot for commit cd2b346. Bugbot is set up for automated code reviews on this repo. Configure here.

catalinradoiu commented Sep 2, 2026

Copy link
Copy Markdown
Contributor Author

@catalinradoiu catalinradoiu changed the title Update icons size and drawables for import complete and import error in the onboarding import flow Update the onboarding password import result row icons and sizing Sep 2, 2026
Base automatically changed from feature/cradoiu/onboarding-password-import-flow to develop September 3, 2026 16:15
Use bold-spanned counts and updated recolorable icons in the import
complete card, and add a missing period to the password import body copy.

Asana: https://app.asana.com/1/137249556945/project/1211724162604201/task/1218143516747353
@catalinradoiu
catalinradoiu force-pushed the fix/cradoiu/onboarding-import-update-assets branch from b068fa4 to cd2b346 Compare September 7, 2026 10:51

@LukasPaczos LukasPaczos left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@catalinradoiu
catalinradoiu added this pull request to the merge queue Sep 7, 2026
Merged via the queue into develop with commit f3e4c39 Sep 7, 2026
31 checks passed
@catalinradoiu
catalinradoiu deleted the fix/cradoiu/onboarding-import-update-assets branch September 7, 2026 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants