Wire the onboarding password import step to the Google import flow

[catalinradoiu]

Task/Issue URL: https://app.asana.com/1/137249556945/project/1201621853593513/task/1217265967787215?focus=true
Tech Design URL (if applicable): https://app.asana.com/1/137249556945/project/481882893211075/task/1217143698674642
API Proposals URL(s) (if applicable): https://app.asana.com/1/137249556945/project/1211724162604201/task/1217824836952478?focus=true

Description

Wire the password import step UI in the linaer onboarding to the existing Google password import web flow.

Add the new -api surface, ImportPasswordsFromGoogle:

• isSupported() - whether the WebView on this device can run the import at all. Used as an enrolment prerequisite so users who could never reach the step are kept out of the experiment.
• parseResult(data) - reads the outcome out of the result intent.
• importStatus() - progress of the import itself, which continues after the web flow returns Success. It replays its most recent value, which is load-bearing here: the onboarding collector attaches after the activity result, so without replay a fast import is missed entirely.

Steps to test this PR

Apply the following patch:

Onboarding + password import test patch

Index: app/src/main/java/com/duckduckgo/app/onboarding/orchestrator/NewUserOnboardingPlanProvider.kt
diff --git a/app/src/main/java/com/duckduckgo/app/onboarding/orchestrator/NewUserOnboardingPlanProvider.kt b/app/src/main/java/com/duckduckgo/app/onboarding/orchestrator/NewUserOnboardingPlanProvider.kt
--- a/app/src/main/java/com/duckduckgo/app/onboarding/orchestrator/NewUserOnboardingPlanProvider.kt
+++ b/app/src/main/java/com/duckduckgo/app/onboarding/orchestrator/NewUserOnboardingPlanProvider.kt
@@ -196,7 +196,7 @@
                     add(widgetPromptStep(ctx))
                     add(addWidgetStep(ctx))
                 }
-                if (showPasswordImport) {
+                if (true) {
                     add(passwordImportStep(ctx))
                     add(passwordImportLaunchStep(ctx))
                     add(passwordImportCompleteStep(ctx))
Index: autofill/autofill-impl/src/main/java/com/duckduckgo/autofill/impl/importing/RealImportPasswordsFromGoogle.kt
diff --git a/autofill/autofill-impl/src/main/java/com/duckduckgo/autofill/impl/importing/RealImportPasswordsFromGoogle.kt b/autofill/autofill-impl/src/main/java/com/duckduckgo/autofill/impl/importing/RealImportPasswordsFromGoogle.kt
--- a/autofill/autofill-impl/src/main/java/com/duckduckgo/autofill/impl/importing/RealImportPasswordsFromGoogle.kt
+++ b/autofill/autofill-impl/src/main/java/com/duckduckgo/autofill/impl/importing/RealImportPasswordsFromGoogle.kt
@@ -38,9 +38,16 @@
     private val credentialImporter: CredentialImporter,
 ) : ImportPasswordsFromGoogle {
 
+    // TODO: LOCAL ONLY - REVERT BEFORE COMMITTING.
+    // Forces every returned web flow to report this result.
+    // null for the real result; Error.Transient for the retry alert; Error.Permanent for the failed outcome card.
+    private val simulatedResult: ImportPasswordsResult? = null //ImportPasswordsResult.Error.Transient
+
     override suspend fun isSupported(): Boolean = capabilityChecker.webViewCapableOfImporting()
 
     override fun parseResult(data: Intent?): ImportPasswordsResult {
+        simulatedResult?.let { return it }
+
         val result = data?.let {
             IntentCompat.getParcelableExtra(it, ImportGooglePasswordResult.RESULT_KEY_DETAILS, ImportGooglePasswordResult::class.java)
         }
Index: autofill/autofill-impl/src/main/java/com/duckduckgo/autofill/impl/importing/CredentialImporter.kt
diff --git a/autofill/autofill-impl/src/main/java/com/duckduckgo/autofill/impl/importing/CredentialImporter.kt b/autofill/autofill-impl/src/main/java/com/duckduckgo/autofill/impl/importing/CredentialImporter.kt
--- a/autofill/autofill-impl/src/main/java/com/duckduckgo/autofill/impl/importing/CredentialImporter.kt
+++ b/autofill/autofill-impl/src/main/java/com/duckduckgo/autofill/impl/importing/CredentialImporter.kt
@@ -28,11 +28,13 @@
 import com.squareup.anvil.annotations.ContributesBinding
 import dagger.SingleInstanceIn
 import kotlinx.coroutines.CoroutineScope
+import kotlinx.coroutines.delay
 import kotlinx.coroutines.flow.Flow
 import kotlinx.coroutines.flow.MutableSharedFlow
 import kotlinx.coroutines.launch
 import kotlinx.parcelize.Parcelize
 import javax.inject.Inject
+import kotlin.time.Duration.Companion.milliseconds
 
 interface CredentialImporter {
     suspend fun import(
@@ -89,6 +91,7 @@
         // mark that the user has imported passwords at least once, regardless of the number of credentials imported
         autofillStore.hasEverImportedPasswords = true
 
+        delay(200.milliseconds)
         _importStatus.emit(Finished(savedCredentials = insertedIds.size, numberSkipped = skippedCredentials))
     }
 

Successful import

• Run onboarding to the import step and tap "Import From Google"
• Complete the Google flow and confirm the outcome card shows the shimmer, then the imported count (and the skipped row when any were skipped)
• Confirm the imported passwords are present in the Passwords & autofill in settings

Cancel

• Tap "Import From Google", then back out of the Google flow
• Confirm you return to the prompt card with no error dialog

Error retry

• Update RealImportPasswordsFromGoogle and set the value of simulatedResult to ImportPasswordsResult.Error.Transient
• "Try again" relaunches the flow; "Cancel" advances to the next onboarding step

Permanent error

• Update RealImportPasswordsFromGoogle and set the value of simulatedResult to ImportPasswordsResult.Error.Permanent
• Go through the import flow
• The error takes you to the import failed step without any retry dialog (this happens in case of a CSV parsing failure)

Skip

• Tap "Skip" and confirm onboarding continues without launching the flow

Existing flow

• Import passwords from the existing in-app entry point from settings and confirm it is unaffected

UI changes

No UI changes, this only wires the import step to the web flow and shows the error dialog in case of a transient error.

---

Note

Medium Risk
Touches onboarding flow state, activity-result handling, and autofill import plumbing; mistakes could strand users on import steps or mis-report experiment pixels, but changes are scoped with substantial test coverage.

Overview
Connects linear onboarding’s password import steps to the existing Google Password Manager web flow via a new autofill ImportPasswordsFromGoogle API (isSupported, parseResult, replaying importStatus).

The config-driven onboarding ViewModel launches AutofillImportPasswordsScreen, maps web-flow results to orchestrator events, shows a retry alert on transient errors (survives rotation), and waits on importStatus (20s timeout) to populate the outcome card. The plan orchestrator tracks passwordImportResult instead of a boolean success flag: transient failures GoBack to the import prompt; permanent failures advance to a failed outcome step; success shows parsing then counts.

Experiment enrollment now also requires isSupported() so unsupported devices are excluded. Existing settings/password-management import entry points switch to the shared AutofillImportPasswordsScreen params; Onboarding is added as a launch source. Telemetry uses explicit outcome value strings (both error kinds report "error").

^{Reviewed by Cursor Bugbot for commit a432797. Bugbot is set up for automated code reviews on this repo. Configure here.}

[catalinradoiu]

• Wire the onboarding password import step to the Google import flow #9624 : 2 dependent PRs (#9674 , #9686 ) 👈 (View in Graphite)
• Add the password import step UI to the onboarding #9623
• develop

This stack of pull requests is managed by Graphite. Learn more about stacking.

[cursor]

Cursor Bugbot has reviewed your changes and found 1 potential issue.

^{❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.}

^{Reviewed by Cursor Bugbot for commit 95a31f7. Configure here.}

[CDRussell]

@catalinradoiu Haven't been through the code; only testing out the functionality. But there's one thing that's definitely needing fixed:

1. go through the import flow
2. on the success screen, hit back button (app backgrounds)
3. when you launch the app again you're shown a in-progress shimmer that never completes (user is stuck here)

[CDRussell]

curious, why InProgress leads to PERMANENT_ERROR?

[catalinradoiu]

When we get the outcome we shouldn't be InProgress anymore. But I agree this is confusing and I will fix this.

[catalinradoiu]

Fixed it to avoid the confusion

[LukasPaczos]

This is called before the content is actually bound. Can we call it at the end of this block? Or if the timing matter, rename the callback?

[catalinradoiu]

I will rename it in the next PR as we discussed