Skip to content

Move to use "mc alias" instead of "mc config"#274

Merged
Tmonster merged 4 commits intoduckdb:mainfrom
carlopi:fix_mc
Jun 3, 2025
Merged

Move to use "mc alias" instead of "mc config"#274
Tmonster merged 4 commits intoduckdb:mainfrom
carlopi:fix_mc

Conversation

@carlopi
Copy link
Copy Markdown
Member

@carlopi carlopi commented Jun 2, 2025

No description provided.

@carlopi
Copy link
Copy Markdown
Member Author

carlopi commented Jun 2, 2025

This should also unlock #267

@carlopi
Copy link
Copy Markdown
Member Author

carlopi commented Jun 2, 2025

Actually adding @c-herrewijn's PR as part of this one, otherwise it does fail.

@carlopi carlopi requested a review from Tishj June 2, 2025 15:02
Copy link
Copy Markdown
Member

@Tmonster Tmonster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if CI passes

@Tmonster Tmonster mentioned this pull request Jun 2, 2025
@kevinjqliu
Copy link
Copy Markdown

similar fix in pyiceberg apache/iceberg-python#2049

@carlopi
Copy link
Copy Markdown
Member Author

carlopi commented Jun 3, 2025

I think this can go in, failure looks also connected to mc, but it's in a different workflow and can be fixed on the side.

@carlopi carlopi mentioned this pull request Jun 3, 2025
@Tmonster
Copy link
Copy Markdown
Member

Tmonster commented Jun 3, 2025

Thanks! I can look into fixing the failure in the Lakekeeper workflow

@Tmonster Tmonster merged commit 64a5c9e into duckdb:main Jun 3, 2025
17 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants