Skip to content

Wasm compatible fixes#276

Merged
Tishj merged 5 commits intoduckdb:mainfrom
carlopi:wasm_compatible_fixes
Jun 17, 2025
Merged

Wasm compatible fixes#276
Tishj merged 5 commits intoduckdb:mainfrom
carlopi:wasm_compatible_fixes

Conversation

@carlopi
Copy link
Copy Markdown
Member

@carlopi carlopi commented Jun 3, 2025

This is on top of #274, that in some version I will assume will go in.

3 changes are:

  • fix build_loadable_extension (currently borked / unusable, even in native)
  • feature select src/aws.cpp depending on EMSCRIPTEN define
  • feature select extension_config.cmake to skip other extensions in wasm

First makes sense in any case, other 2 should have no influence on native compilation.

@carlopi
Copy link
Copy Markdown
Member Author

carlopi commented Jun 3, 2025

This is ready on my side, not really urgent, whenever.

Copy link
Copy Markdown
Member

@Tmonster Tmonster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Tishj Tishj merged commit 9ecdbab into duckdb:main Jun 17, 2025
18 checks passed
@carlopi carlopi deleted the wasm_compatible_fixes branch June 17, 2025 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants