fix(ansible-ci): run molecule when tests/ changes#119
Merged
openbao-service-broker[bot] merged 1 commit intoJul 24, 2026
Conversation
The molecule filter covered roles/, molecule/, .config/molecule/ and requirements.yml, but consuming repos keep suites under tests/ that run as molecule-workflow jobs. A change confined to one of those suites left the filter false, skipped every molecule job, and merged green without ever running the test it changed. Assisted-by: Claude:claude-opus-5 Claude-Session: https://claude.ai/code/session_01Kqn6PLZhCzVdfLt7E7EFMg
openbao-service-broker
Bot
deleted the
fix/molecule-filter-template-render
branch
July 24, 2026 21:21
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The blind spot
The shared
moleculepaths-filter coversroles/,molecule/,.config/molecule/andrequirements.yml— but consuming repos keep suites undertests/that run as jobs of the molecule workflow (ansible-proxmox-apps hastests/template_render/as Molecule / Template Rendering Tests, andtests/nautobot_seed/).A change confined to one of those suites leaves the filter false, skips every molecule job, and the PR merges green without ever running the test it changed.
What that cost today
Two PRs fixing
tests/template_render/verify_templates.ymlmerged green while leavingdevelopred — the render test was failing on develop HEAD throughout, and neither PR's CI could exercise its own fix. Local runs were the only evidence available at merge time. Two agents hit this independently and both flagged it.Change
One entry,
tests/**, with a comment explaining why it exists so nobody removes it as redundant. Deliberatelytests/**rather than a specific path, so a consumer adding a new suite is covered by default: the failure mode here is a filter that is too narrow, and an unnecessary molecule run is far cheaper than a test that silently never runs.YAML parses clean.
🤖 Generated with Claude Code