ci(ansible): trigger molecule filter on template-render test changes#118
Closed
openbao-service-broker[bot] wants to merge 1 commit into
Closed
ci(ansible): trigger molecule filter on template-render test changes#118openbao-service-broker[bot] wants to merge 1 commit into
openbao-service-broker[bot] wants to merge 1 commit into
Conversation
The `molecule` path filter covered roles, molecule scenarios and requirements, but not the render-test playbooks that consume them. Callers that keep a local molecule workflow gate their template-render job on this same output, so a PR touching only tests/template_render/ reported green without that job ever running. That is not hypothetical: dryvist/ansible-proxmox-apps#1258 changed the render playbook's privilege handling, merged unexercised, and broke the template-render job on every self-hosted runner. Inert for the other consumers - ansible-proxmox, ansible-proxmox-ai and ansible-splunk have no tests/template_render/ directory, so the new pattern cannot match anything there and their molecule gating is unchanged. Assisted-by: Claude:claude-opus-5 Claude-Session: https://claude.ai/code/session_01Kqn6PLZhCzVdfLt7E7EFMg
This was referenced Jul 24, 2026
Closed
Closed
Contributor
Author
|
Closing as a duplicate of #119, which fixes the same gap with a broader filter. Two agents reached this independently, which is good corroboration that the blind spot is real. Keeping the broader form because this narrower one is already provably insufficient: Your comment explaining why the entry exists was better than mine and I have carried the substance of it across. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
moleculepath filter gates the molecule job — and, for callers that keep a local molecule workflow, their template-render job hangs off the same output. The filter coversroles/**,molecule/**,.config/molecule/**andrequirements.yml, but not the render-test playbooks that consume those roles.So a PR that changes only
tests/template_render/reports green without that job ever running.That is not hypothetical. dryvist/ansible-proxmox-apps#1258 changed the render playbook's privilege handling, merged unexercised because of this gap, and broke the template-render job on every self-hosted runner — the unprivileged render could no longer overwrite root-owned leftovers at its fixed
/tmppaths. The root-cause fix is dryvist/ansible-proxmox-apps#PLACEHOLDER; this closes the hole that let it land unseen.Change
One pattern added to the
moleculefilter:- 'tests/template_render/**'Effect on other consumers
_ansible-ci.ymlis consumed by four repos. Checked each for atests/template_render/directory:tests/template_render/ansible-proxmox-appsansible-proxmoxansible-proxmox-aiansible-splunktests/templates/, a different path)The two repos that use the shared molecule job (
ansible-proxmox,ansible-splunk) are unaffected: the path does not exist in either, so the filter output cannot change for them. A broadertests/**pattern would have changed their gating, which is why this is scoped to the one directory.🤖 Generated with Claude Code
https://claude.ai/code/session_01Kqn6PLZhCzVdfLt7E7EFMg