Remove the package zip cache download#54503
Open
marcpopMSFT wants to merge 1 commit into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Backports the removal of the pre-downloaded SDK test packages zip cache (originally landed in main via #52660) to the release/10 branch to reduce per-work-item test runtime, which is currently ~48s vs ~29s on main. Also extends the existing list of removed NuGet sources to include dotnet8/9/10 transport and internal-transport feeds so test runs don't fan out parallel requests to those AzDO feeds.
Changes:
- Remove
SDKTestRunPackages.zipandSDKTestRunPackages2.zipHelix correlation payload downloads fromtest/UnitTests.proj. - Remove the now-stale "downloaded a special zip" comment and the Windows-only NuGet
.datcache measurement post-step from the Helix setup scripts. - Add
dotnet nuget remove sourcecalls fordotnet{8,9,10}-transportand their-internal-transportcounterparts in both the.shand.cmdHelix setup scripts.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| test/UnitTests.proj | Drops the two HelixCorrelationPayload entries that downloaded the prebuilt SDK test packages zips into d/.nuget. |
| build/RunTestsOnHelix.sh | Removes obsolete comment and adds removal of dotnet8/9/10 (internal-)transport sources from the per-work-item NuGet.config. |
| build/RunTestsOnHelix.cmd | Mirrors the .sh changes and additionally drops the PowerShell .dat cache-size measurement line. |
akoeplinger
approved these changes
May 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove additional transport feeds from the test nuget.config. We call all in parallel during the tests so it explodes our volume of azdo feed calls.
This has been removed in main for a while without negative impact that we can tell. See #52660. From internal data, the download time in main is ~29 seconds per work item but in 10 branches, its close to 48. We believe this change is the predominant cause of that delta.
It should be safe to remove from 10 as we have limited codeflow there because of low number of branding PRs. Leaving in 8/9 for now as those still have a large number of branding flows each month and so could still need this.