Skip to content

feat(dependencies): build provider dependency foundations - #1588

Draft
skevetter wants to merge 31 commits into
mainfrom
feat/provider-deps-t00a-finalize
Draft

skevetter wants to merge 31 commits into
mainfrom
feat/provider-deps-t00a-finalize

Conversation

@skevetter

@skevetter skevetter commented Oct 19, 2026 •

Copy link
Copy Markdown
Contributor

Cause

Passive provider inspection lacked a Desktop entry point and rejected normally installed built-ins because icon installation generates an IconRevision. Two shipped-process tests nested Go builds inside a concurrent macOS package matrix.

Fix

Merged main and resolved conflicts. Added passive inspection and guidance in Desktop. Compared author-controlled manifest fields without the generated icon revision. Moved both process tests into a separate race-enabled CI stage. Managed actions remain disabled.

Test evidence

fb202c7: go test -p 1 -race -count=1 ./pkg/workspace (1 package passed, 0 failed); mise run cli:lint:ci (0 issues); mise exec -- prek run --all-files (13 hooks passed, 0 failed). Four installed-provider regression cases failed before and passed after. An isolated built CLI added and inspected Docker with exit 0 in both commands. GitHub core run 41711209236 and Desktop run 41711209264 passed (2 workflows, 0 failed). Greptile scored 5/5 with zero final-head comments. All review threads are resolved.

Not verified

CodeRabbit skipped its review because the PR changes 117 files and its limit is 100. The adapter is unreleased. Managed installation, selection, removal, current-user KVM lifecycle, release-owner license review, and native macOS Electron UI are not verified. The owner selected no enforceable old-client cutoff, so removal remains disabled. No merge.

@skevetter skevetter added the provider-dependencies Provider Dependencies rollout and evidence-gated implementation label Oct 19, 2026
@netlify

netlify Bot commented Oct 19, 2026 •

Copy link
Copy Markdown

✅ Deploy Preview for devsydev canceled.

Name Link
🔨 Latest commit fb202c7
🔍 Latest deploy log https://app.netlify.com/projects/devsydev/deploys/6aea4159cc0d9521c72b3438

@netlify

netlify Bot commented Oct 19, 2026 •

Copy link
Copy Markdown

✅ Deploy Preview for images-devsy-sh canceled.

Name Link
🔨 Latest commit fb202c7
🔍 Latest deploy log https://app.netlify.com/projects/images-devsy-sh/deploys/6aea41598ece4ee34bbfa0b7

@coderabbitai

coderabbitai Bot commented Oct 19, 2026 •

Copy link
Copy Markdown

Important

Review skipped

Too many files!

This PR contains 117 files, which is 17 over the limit of 100.

To get a review, reduce the PR to 100 files or fewer by splitting it into smaller PRs or changing its base branch.

Upgrade to a paid plan to raise the limit.

This review couldn't start because sufficient usage credits or metered capacity aren't available. Add credits or update usage-based reviews in the billing tab, then retry.

Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 4cc5bd11-fab3-4bbf-9e16-7b49e5a8181a
Commits

Reviewing files that changed from the base of the PR and between 161bc10 and fb202c7.

Files selected for processing: 117
  • cmd/container_test.go
  • cmd/dependency/dependency.go
  • cmd/dependency/inspect.go
  • cmd/dependency/inspect_snapshot.go
  • cmd/dependency/inspect_test.go
  • cmd/flags/inspection.go
  • cmd/flags/inspection_test.go
  • cmd/flags/passive.go
  • cmd/flags/passive_test.go
  • cmd/inspect_process_unix_test.go
  • cmd/invocation_output.go
  • cmd/invocation_output_test.go
  • cmd/passive.go
  • cmd/passive_process_test.go
  • cmd/passive_test.go
  • cmd/root.go
  • desktop/src/main/__tests__/ipc-provider-icon.test.ts
  • desktop/src/main/ipc.ts
  • desktop/src/renderer/src/lib/components/provider/ProviderSheet.svelte
  • desktop/src/renderer/src/lib/components/provider/ProviderSheet.test.ts
  • desktop/src/renderer/src/lib/components/provider/ProviderWizard.svelte
  • desktop/src/renderer/src/lib/components/provider/ProviderWizard.test.ts
  • desktop/src/renderer/src/lib/ipc/commands.ts
  • desktop/src/renderer/src/lib/utils/provider-source.ts
  • hack/ci/suites.yaml
  • internal/dependencytest/guards.go
  • internal/dependencytest/guards_test.go
  • internal/dependencytest/lockorder.go
  • internal/dependencytest/lockorder_test.go
  • internal/dependencytest/locks_test.go
  • pkg/config/config.go
  • pkg/config/config_readonly_test.go
  • pkg/config/context_deletion.go
  • pkg/config/context_deletion_readonly_test.go
  • pkg/config/pathmanager.go
  • pkg/config/pathmanager_darwin.go
  • pkg/config/pathmanager_darwin_test.go
  • pkg/config/pathmanager_dependencies_test.go
  • pkg/config/pathmanager_explicit_home_test.go
  • pkg/config/pathmanager_linux.go
  • pkg/config/pathmanager_linux_test.go
  • pkg/config/pathmanager_readonly_test.go
  • pkg/config/pathmanager_unix.go
  • pkg/config/pathmanager_unix_test.go
  • pkg/config/pathmanager_windows.go
  • pkg/config/pathmanager_windows_test.go
  • pkg/dependencies/catalog.go
  • pkg/dependencies/catalog/v1.json
  • pkg/dependencies/catalog_recipe.go
  • pkg/dependencies/catalog_test.go
  • pkg/dependencies/catalog_types.go
  • pkg/dependencies/catalog_validate.go
  • pkg/dependencies/catalog_validation_test.go
  • pkg/dependencies/contracts_test.go
  • pkg/dependencies/inspect_contracts_test.go
  • pkg/dependencies/journal.go
  • pkg/dependencies/lookup.go
  • pkg/dependencies/lookup_environment.go
  • pkg/dependencies/lookup_observe.go
  • pkg/dependencies/lookup_platform.go
  • pkg/dependencies/lookup_safety.go
  • pkg/dependencies/lookup_safety_test.go
  • pkg/dependencies/lookup_safety_unix.go
  • pkg/dependencies/lookup_safety_unix_test.go
  • pkg/dependencies/lookup_safety_windows.go
  • pkg/dependencies/lookup_safety_windows_test.go
  • pkg/dependencies/lookup_test.go
  • pkg/dependencies/lookup_windows_test.go
  • pkg/dependencies/metadata_codec.go
  • pkg/dependencies/metadata_codec_test.go
  • pkg/dependencies/metadata_write.go
  • pkg/dependencies/metadata_write_unix.go
  • pkg/dependencies/metadata_write_unix_test.go
  • pkg/dependencies/metadata_write_unsupported.go
  • pkg/dependencies/metadata_write_unsupported_test.go
  • pkg/dependencies/receipt.go
  • pkg/dependencies/registry.go
  • pkg/dependencies/report.go
  • pkg/dependencies/report_contracts_test.go
  • pkg/dependencies/report_test.go
  • pkg/dependencies/report_types.go
  • pkg/dependencies/report_validation_test.go
  • pkg/dependencies/survey.go
  • pkg/dependencies/survey_availability.go
  • pkg/dependencies/survey_safety_test.go
  • pkg/dependencies/survey_test.go
  • pkg/dependencies/survey_types.go
  • pkg/dependencies/testdata/contracts/BASELINE_AND_GUARD_MAP.md
  • pkg/dependencies/testdata/contracts/report_configuration_conflict.json
  • pkg/dependencies/testdata/contracts/report_external.json
  • pkg/dependencies/testdata/contracts/report_incomplete_pair.json
  • pkg/dependencies/testdata/contracts/report_managed_disabled_candidate.json
  • pkg/dependencies/testdata/contracts/report_missing.json
  • pkg/dependencies/testdata/contracts/report_offline_asset_missing.json
  • pkg/dependencies/testdata/contracts/report_stale_target.json
  • pkg/dependencies/testdata/contracts/report_stopped_runtime.json
  • pkg/dependencies/testdata/contracts/report_unknown_custom_source.json
  • pkg/dependencies/testdata/contracts/report_unsupported_host.json
  • pkg/dependencies/testdata/contracts/schema.json
  • pkg/options/resolver/resolver_test.go
  • pkg/platform/client/cache_init_test.go
  • pkg/platform/client/cache_permissions_unix_test.go
  • pkg/platform/client/client.go
  • pkg/provider/dir.go
  • pkg/provider/dir_readonly_test.go
  • pkg/provider/external_test.go
  • pkg/workspace/provider_dependencies.go
  • pkg/workspace/provider_dependencies_contract.go
  • pkg/workspace/provider_dependencies_loaders_test.go
  • pkg/workspace/provider_dependencies_options.go
  • pkg/workspace/provider_dependencies_options_safety_test.go
  • pkg/workspace/provider_dependencies_options_test.go
  • pkg/workspace/provider_dependencies_safety_test.go
  • pkg/workspace/provider_dependencies_test.go
  • pkg/workspace/provider_deprecation_test.go
  • pkg/workspace/provider_icons_regression_test.go
  • sites/docs-devsy-sh/content/docs/managing-providers/manage-providers.mdx

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

CodeRabbit Verify

  • Run CodeRabbit Verify to test the changes in this pull request.

@skevetter

Copy link
Copy Markdown
Contributor Author

@greptileai review

Please review the current head 92ceb40d7452d38faec2a7a6f2d9fb8dfc685549. Implementation CI is complete and passing on this SHA. This PR contains T00a test/fixture/source-ledger scaffolding; executable T00b guards and managed-runtime qualification remain separate.

@greptile-apps

greptile-apps Bot commented Oct 19, 2026 •

Copy link
Copy Markdown

RetriggerView in GreptileConfidence Score: 5/5

[Medium impact] The latest changes appear safe to merge; no new blocking issue was found.

Summary

This PR adds passive provider dependency inspection in the CLI and Desktop. Managed installation, selection, and removal remain disabled.

  • Provider dependency reports now follow a checked catalog contract.
  • The CLI can inspect a saved built-in provider without running it.
  • Desktop shows built-in dependency status during provider setup and settings.
  • The platform cache is created only when a save needs it.
  • Shipped-process tests run after package race tests.

Reviews (3) · Last reviewed commit: "fix(dependencies): accept generated inst..." · Reviewed by Greptile

Comment thread pkg/dependencies/contracts_test.go Resolved
Comment thread pkg/dependencies/contracts_test.go Resolved
@skevetter skevetter changed the title test(dependencies): add provider dependency contract fixtures feat(dependencies): build provider dependency foundations Oct 19, 2026
@skevetter

Copy link
Copy Markdown
Contributor Author

@greptileai review

@skevetter

Copy link
Copy Markdown
Contributor Author

@coderabbitai full review

@coderabbitai

coderabbitai Bot commented Nov 3, 2026 •

Copy link
Copy Markdown
Action not completed

Review rate limited.


Your included review limit is currently reached under our Fair Usage Limits Policy. This review may still proceed through usage-based billing if eligible. Your next included review will be available in 16 minutes.

@skevetter

Copy link
Copy Markdown
Contributor Author

@greptileai review

@skevetter

Copy link
Copy Markdown
Contributor Author

@coderabbitai full review

@coderabbitai

coderabbitai Bot commented Nov 3, 2026 •

Copy link
Copy Markdown
Action not completed

Review skipped: 117 files exceed the limit of 100.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

provider-dependencies Provider Dependencies rollout and evidence-gated implementation size/xl

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant