Repository navigation
refactor(platform): share form option pickers with daemonclient - #1550
Conversation
daemonclient/form.go duplicated the huh option and parameter helpers already in platform/form. Export the platform copies and call them from daemonclient; delete the duplicate block. No behaviour change.
✅ Deploy Preview for images-devsy-sh canceled.
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
📝 Walkthrough
Merge Risk: ⚪ Minimal · up to
|
✅ Deploy Preview for devsydev canceled.
|
|
This pull request does not currently match the merge queue conditions, so it cannot be queued from here. The box comes back if it matches again. |
Summary
pkg/platform/formanddaemonclient.ProjectOptions,ClusterOptions,TemplateOptions,TemplateVersionOptionsinpkg/platform/form.daemonclient/form.gocallsform.*and drops itsProjectOption,TemplateOption,CancelFuncaliases and the four picker copies.Why
The four picker functions were duplicated with only the client type name differing. One copy removes drift risk. No behaviour or output change.
Validation
go build ./...go vet ./pkg/platform/... ./pkg/client/...GOOS=windows go build ./pkg/platform/... ./pkg/client/... ./cmd/...go build ./cmd/pro/provider/create/... ./cmd/pro/provider/update/...go test ./pkg/platform/... ./pkg/client/clientimplementation/daemonclient/...mise run cli:formatmise run cli:lint:ci(0 issues)CodeRabbit CLI
Commit
3108ecc88: rate-limited (free OSS quota, 22 min wait). Prior commitabc334cbcon the same files: 0 findings. Re-run pending.Auto-merge
Next
Share the parameter-field helpers (FieldParameter, PrepareParameters, ParameterFields, RenderParameters, ~100 lines) and then unify create/update flows.
Summary by CodeRabbit