Skip to content

refactor(platform): reuse form.UpdateInstance in daemonclient - #1567

Merged
skevetter merged 1 commit into
mainfrom
refactor/daemonclient-reuse-form-update
Oct 19, 2026
Merged

skevetter merged 1 commit into
mainfrom
refactor/daemonclient-reuse-form-update

Conversation

@skevetter

Copy link
Copy Markdown
Contributor

Summary

  • Delete updateInstanceInteractive and its 7 private helpers from daemonclient/form.go (221 lines).
  • daemonclient/update.go calls form.UpdateInstance from pkg/platform/form.
  • Prune now-unused imports in form.go and add the form import in update.go.
  • Create flow (createInstanceInteractive and helpers) is unchanged.

Why

daemonclient carries a verbatim copy of form.UpdateInstance: template and version select, parameter resolution with existing values, and applyInstanceChanges on a DeepCopy. After this change there is one implementation. This is the next slice of the form dedupe after #1550 and #1558.

Validation

  • mise run cli:format (only the two touched files changed)
  • mise run cli:lint:ci (0 issues)
  • go build ./...
  • go vet ./pkg/client/... ./pkg/platform/...
  • go test ./pkg/client/clientimplementation/daemonclient/... ./pkg/platform/... (ok)
  • grep for the deleted helper names across the repo, including tests: no remaining references.

CodeRabbit CLI

Failed: coderabbit review --agent --committed returned Rate limit exceeded (OSS free-review quota used; CLI reports a ~38 minute wait). The GitHub CodeRabbit review still gates.

Auto-merge

Eligible: yes. 224 changed non-test source lines (221 deleted in form.go, 3 changed in update.go), 2 files, no test changes, no behaviour, text, or exported API change, no lint rule disabled or //nolint added.

Next

Create flows differ: daemonclient sets Target.Cluster, platform/form.CreateInstance does not. They are not unified here.

@skevetter skevetter added the surface-refactor Unattended refactor (surface) label Oct 19, 2026
@netlify

netlify Bot commented Oct 19, 2026 •

Copy link
Copy Markdown

✅ Deploy Preview for images-devsy-sh canceled.

Name Link
🔨 Latest commit acfaa3f
🔍 Latest deploy log https://app.netlify.com/projects/images-devsy-sh/deploys/6ad56633e35ac217c59b581a

@netlify

netlify Bot commented Oct 19, 2026 •

Copy link
Copy Markdown

✅ Deploy Preview for devsydev canceled.

Name Link
🔨 Latest commit acfaa3f
🔍 Latest deploy log https://app.netlify.com/projects/devsydev/deploys/6ad566336bfc20fb52a4dce5

@coderabbitai

coderabbitai Bot commented Oct 19, 2026 •

Copy link
Copy Markdown

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 35 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used all 2 included reviews currently available.

Learn how review limits work.

Review configuration:

⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 5101c82e-1a04-4378-977e-7426647ee7cc
📥 Commits

Reviewing files that changed from the base of the PR and between 6839175 and acfaa3f.

📒 Files selected for processing: 2
  • pkg/client/clientimplementation/daemonclient/form.go
  • pkg/client/clientimplementation/daemonclient/update.go
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@skevetter
skevetter marked this pull request as ready for review October 19, 2026 00:45
@mergify

mergify Bot commented Oct 19, 2026 •

Copy link
Copy Markdown

This pull request does not currently match the merge queue conditions, so it cannot be queued from here. The box comes back if it matches again.

@skevetter

Copy link
Copy Markdown
Contributor Author

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Oct 19, 2026 •

Copy link
Copy Markdown
⚠️ Action not completed

Review rate limited.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@skevetter
skevetter merged commit ac03854 into main Oct 19, 2026
111 checks passed
@skevetter
skevetter deleted the refactor/daemonclient-reuse-form-update branch October 19, 2026 01:58
@skevetter

Copy link
Copy Markdown
Contributor Author

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Oct 19, 2026 •

Copy link
Copy Markdown
⚠️ Action not completed

Pull request is closed.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@skevetter

Copy link
Copy Markdown
Contributor Author

Needs human: CI green on acfaa3f, 0 unresolved threads, but CodeRabbit never produced a review (free OSS quota exhausted; CLI and GitHub both rate-limited, retriggered twice). Status context reads success without a review, so auto-merge is withheld.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/l surface-refactor Unattended refactor (surface)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant