You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
refactor(platform): reuse form.UpdateInstance in daemonclient - #1567
Delete updateInstanceInteractive and its 7 private helpers from daemonclient/form.go (221 lines).
daemonclient/update.go calls form.UpdateInstance from pkg/platform/form.
Prune now-unused imports in form.go and add the form import in update.go.
Create flow (createInstanceInteractive and helpers) is unchanged.
Why
daemonclient carries a verbatim copy of form.UpdateInstance: template and version select, parameter resolution with existing values, and applyInstanceChanges on a DeepCopy. After this change there is one implementation. This is the next slice of the form dedupe after #1550 and #1558.
Validation
mise run cli:format (only the two touched files changed)
mise run cli:lint:ci (0 issues)
go build ./...
go vet ./pkg/client/... ./pkg/platform/...
go test ./pkg/client/clientimplementation/daemonclient/... ./pkg/platform/... (ok)
grep for the deleted helper names across the repo, including tests: no remaining references.
CodeRabbit CLI
Failed: coderabbit review --agent --committed returned Rate limit exceeded (OSS free-review quota used; CLI reports a ~38 minute wait). The GitHub CodeRabbit review still gates.
Auto-merge
Eligible: yes. 224 changed non-test source lines (221 deleted in form.go, 3 changed in update.go), 2 files, no test changes, no behaviour, text, or exported API change, no lint rule disabled or //nolint added.
Next
Create flows differ: daemonclient sets Target.Cluster, platform/form.CreateInstance does not. They are not unified here.
Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.
Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.
Needs human: CI green on acfaa3f, 0 unresolved threads, but CodeRabbit never produced a review (free OSS quota exhausted; CLI and GitHub both rate-limited, retriggered twice). Status context reads success without a review, so auto-merge is withheld.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
updateInstanceInteractiveand its 7 private helpers fromdaemonclient/form.go(221 lines).daemonclient/update.gocallsform.UpdateInstancefrompkg/platform/form.form.goand add theformimport inupdate.go.createInstanceInteractiveand helpers) is unchanged.Why
daemonclientcarries a verbatim copy ofform.UpdateInstance: template and version select, parameter resolution with existing values, andapplyInstanceChangeson aDeepCopy. After this change there is one implementation. This is the next slice of the form dedupe after #1550 and #1558.Validation
mise run cli:format(only the two touched files changed)mise run cli:lint:ci(0 issues)go build ./...go vet ./pkg/client/... ./pkg/platform/...go test ./pkg/client/clientimplementation/daemonclient/... ./pkg/platform/...(ok)grepfor the deleted helper names across the repo, including tests: no remaining references.CodeRabbit CLI
Failed:
coderabbit review --agent --committedreturnedRate limit exceeded(OSS free-review quota used; CLI reports a ~38 minute wait). The GitHub CodeRabbit review still gates.Auto-merge
Eligible: yes. 224 changed non-test source lines (221 deleted in
form.go, 3 changed inupdate.go), 2 files, no test changes, no behaviour, text, or exported API change, no lint rule disabled or//nolintadded.Next
Create flows differ:
daemonclientsetsTarget.Cluster,platform/form.CreateInstancedoes not. They are not unified here.