Skip to content

refactor(pro): split start command by concern - #1548

Merged
skevetter merged 1 commit into
mainfrom
refactor/pro-split-start-command
Oct 18, 2026
Merged

skevetter merged 1 commit into
mainfrom
refactor/pro-split-start-command

Conversation

@skevetter

Copy link
Copy Markdown
Contributor

Summary

  • Move uninstall and its helpers (runHelmUninstall, cleanupProResources, deleteRemainingAgentResources, resolveReleaseName, deleteIgnoreNotFound) and deleteUser out of cmd/pro/start.go into cmd/pro/start_uninstall.go.
  • uninstall now takes a uninstallTarget{kubeContext, namespace} struct instead of two strings, to satisfy the 4-argument limit. The two callers in start.go (prepareKubernetes, prepareInstall) are updated; behaviour is unchanged.
  • The helm flag literals in runHelmUninstall use the new helmKubeContextFlag and helmNamespaceFlag constants.
  • start.go goes from 1753 to 1572 lines. Login and ingress/admin-password code stay in start.go.

Why

start.go mixes uninstall, login, and install concerns. Splitting out uninstall gives it one file. Login was dropped from this PR because moving it made new gosec findings (G117, G402) show as new code. Those findings are pre-existing and must not be suppressed here.

Validation

  • mise run cli:format: clean
  • mise run cli:lint:ci: 0 issues
  • golangci-lint run --new-from-rev=origin/main ./cmd/pro/...: 0 issues
  • go build ./...: ok
  • go test ./cmd/pro/...: ok

CodeRabbit CLI

coderabbit review --agent --committed on c37fe642a: completed, 0 findings, 2 files reviewed.

Auto-merge

Draft only. Not merged. Needs human review because uninstall's signature changed (args bundled into a struct), so this is not a pure move.

@skevetter skevetter added the auto-refactor Automated refactor PR label Oct 18, 2026
@netlify

netlify Bot commented Oct 18, 2026 •

Copy link
Copy Markdown

✅ Deploy Preview for images-devsy-sh canceled.

Name Link
🔨 Latest commit c37fe64
🔍 Latest deploy log https://app.netlify.com/projects/images-devsy-sh/deploys/6ad4efe6179f225ed9bea069

@coderabbitai

coderabbitai Bot commented Oct 18, 2026 •

Copy link
Copy Markdown

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 11 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used all 2 included reviews currently available.

Learn how review limits work.

Review configuration:

⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: a57c6b94-810f-45a9-a980-fb28af8b448c
📥 Commits

Reviewing files that changed from the base of the PR and between 5f2e1e2 and c37fe64.

📒 Files selected for processing: 2
  • cmd/pro/start.go
  • cmd/pro/start_uninstall.go
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@netlify

netlify Bot commented Oct 18, 2026 •

Copy link
Copy Markdown

✅ Deploy Preview for devsydev canceled.

Name Link
🔨 Latest commit c37fe64
🔍 Latest deploy log https://app.netlify.com/projects/devsydev/deploys/6ad4efe7cc5940d699fbbcbe

@skevetter
skevetter marked this pull request as ready for review October 18, 2026 17:06
@mergify

mergify Bot commented Oct 18, 2026 •

Copy link
Copy Markdown

This pull request does not currently match the merge queue conditions, so it cannot be queued from here. The box comes back if it matches again.

@skevetter

Copy link
Copy Markdown
Contributor Author

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Oct 18, 2026 •

Copy link
Copy Markdown
⚠️ Action not completed

Review rate limited.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@skevetter

Copy link
Copy Markdown
Contributor Author

@coderabbitai full review

@coderabbitai

coderabbitai Bot commented Oct 18, 2026 •

Copy link
Copy Markdown
⚠️ Action not completed

Review rate limited.


Your included review limit is currently reached under our Fair Usage Limits Policy. This review may still proceed through usage-based billing if eligible. Your next included review will be available in 11 minutes.

@skevetter

Copy link
Copy Markdown
Contributor Author

Auto-refactor: not merged. CI is green on c37fe64, but the CodeRabbit GitHub review never ran (status "Review rate limited" after 3 requests, ~2.5h). Review gate unmet; needs a human, or re-request CodeRabbit once the free limit resets.

@skevetter
skevetter merged commit 61e6d1a into main Oct 18, 2026
111 checks passed
@skevetter
skevetter deleted the refactor/pro-split-start-command branch October 18, 2026 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

auto-refactor Automated refactor PR size/l

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant