You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
refactor(platform): rename kube Loft accessor to Devsy - #1552
Renames the kube client Loft() accessor to Devsy() and updates all callers. Renames the loftclient/loftfake/loftClient identifiers to devsyclient/devsyfake/devsyClient in the touched files. Test helper field and method become devsy/Devsy(). Error text becomes create devsy client.
Why
Tracker: #1551. Continues the Loft to Devsy rename without changing behaviour.
Tier
T1 (internal). No contract, wire, CLI, or env change. Helm release/chart names, EnvLoft*, and LoftDirectClusterEndpoint are unchanged.
Validation
mkdir -p dist && go build ./...: pass
GOOS=windows go vet ./pkg/platform/... ./pkg/daemon/... ./pkg/client/... ./cmd/...: pass
mise run cli:format: pass (no further diffs)
mise run cli:lint:ci: 0 issues
go test ./pkg/platform/... ./pkg/daemon/... ./pkg/client/... ./cmd/...: pass
CodeRabbit CLI
coderabbit review --agent --committed --base-commit 675485e8: completed, 0 findings. The first attempt was rate-limited; the retry succeeded.
Loft-token count in the touched set: Loft()|loftclient|loftfake|loftClient 79 to 8 (remaining 8 are all in cmd/pro/start.go, owned by #1548). Case-insensitive loft total: 217 to 142.
Next
T2: env and annotation constants (EnvLoft*, LoftDirectClusterEndpoint)
Cluster, project, template, workspace, user, and access-key operations now use the Devsy management service.
Workspace lifecycle actions—including creation, troubleshooting, sleep, wake, stop, and deletion—also use Devsy. Existing commands and their behavior remain unchanged.
Included review availability: This review used your included allowance. Your plan provides up to 2 included reviews per hour; 0 remain after this review.
📝 Walkthrough
The pull request replaces Loft client access with Devsy client access across CLI commands, platform operations, and daemon code. It also updates the Kubernetes wrapper and related tests to construct and expose Devsy clients. Existing request arguments and surrounding behavior remain unchanged.
The client rename preserves the existing management operations, so no user-facing behavior change is identified. The PR has no outstanding mergeability concern from this review.
Pre-merge checks: 4 · 1
Failed checks: 1 warning
Check name
Status
Explanation
Resolution
Docstring Coverage
Docstring coverage is 20.69% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 29 functions across 22 files.
Write docstrings for the functions missing them to satisfy the coverage threshold.
Passed checks: 4 passed
Check name
Status
Explanation
Description Check
Check skipped - CodeRabbit’s high-level summary is enabled.
Title check
The title clearly and concisely identifies the main change: renaming the platform kube client accessor from Loft to Devsy.
Linked Issues check
Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check
Check skipped because no linked issues were found for this pull request.
Fix all pre-merge checks with AI
✨ Finishing Touches
✨ Simplify code
Commit to this branch
Create a new PR
Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Renames the kube client
Loft()accessor toDevsy()and updates all callers. Renames theloftclient/loftfake/loftClientidentifiers todevsyclient/devsyfake/devsyClientin the touched files. Test helper field and method becomedevsy/Devsy(). Error text becomescreate devsy client.Why
Tracker: #1551. Continues the Loft to Devsy rename without changing behaviour.
Tier
T1 (internal). No contract, wire, CLI, or env change. Helm release/chart names,
EnvLoft*, andLoftDirectClusterEndpointare unchanged.Validation
mkdir -p dist && go build ./...: passGOOS=windows go vet ./pkg/platform/... ./pkg/daemon/... ./pkg/client/... ./cmd/...: passmise run cli:format: pass (no further diffs)mise run cli:lint:ci: 0 issuesgo test ./pkg/platform/... ./pkg/daemon/... ./pkg/client/... ./cmd/...: passCodeRabbit CLI
coderabbit review --agent --committed --base-commit 675485e8: completed, 0 findings. The first attempt was rate-limited; the retry succeeded.Auto-merge
Eligible: yes (T1). Non-test changed lines: 76 added, 77 deleted (22 files, 1 test file).
Remaining
Loft-token count in the touched set:
Loft()|loftclient|loftfake|loftClient79 to 8 (remaining 8 are all incmd/pro/start.go, owned by #1548). Case-insensitivelofttotal: 217 to 142.Next
EnvLoft*,LoftDirectClusterEndpoint)pkg/platformlocals (e.g.loftURL, "loft instance/endpoint" messages)cmd/pro/start*.goafter refactor(pro): split start command by concern #1548 mergesSummary by CodeRabbit