Skip to content

refactor(platform): rename kube Loft accessor to Devsy - #1552

Merged
skevetter merged 1 commit into
mainfrom
refactor/rename-loft-kube-accessor
Oct 18, 2026
Merged

skevetter merged 1 commit into
mainfrom
refactor/rename-loft-kube-accessor

Conversation

@skevetter

@skevetter skevetter commented Oct 18, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Renames the kube client Loft() accessor to Devsy() and updates all callers. Renames the loftclient/loftfake/loftClient identifiers to devsyclient/devsyfake/devsyClient in the touched files. Test helper field and method become devsy/Devsy(). Error text becomes create devsy client.

Why

Tracker: #1551. Continues the Loft to Devsy rename without changing behaviour.

Tier

T1 (internal). No contract, wire, CLI, or env change. Helm release/chart names, EnvLoft*, and LoftDirectClusterEndpoint are unchanged.

Validation

  • mkdir -p dist && go build ./...: pass
  • GOOS=windows go vet ./pkg/platform/... ./pkg/daemon/... ./pkg/client/... ./cmd/...: pass
  • mise run cli:format: pass (no further diffs)
  • mise run cli:lint:ci: 0 issues
  • go test ./pkg/platform/... ./pkg/daemon/... ./pkg/client/... ./cmd/...: pass

CodeRabbit CLI

coderabbit review --agent --committed --base-commit 675485e8: completed, 0 findings. The first attempt was rate-limited; the retry succeeded.

Auto-merge

Eligible: yes (T1). Non-test changed lines: 76 added, 77 deleted (22 files, 1 test file).

Remaining

Loft-token count in the touched set: Loft()|loftclient|loftfake|loftClient 79 to 8 (remaining 8 are all in cmd/pro/start.go, owned by #1548). Case-insensitive loft total: 217 to 142.

Next

Summary by CodeRabbit

  • Updates
    • Cluster, project, template, workspace, user, and access-key operations now use the Devsy management service.
    • Workspace lifecycle actions—including creation, troubleshooting, sleep, wake, stop, and deletion—also use Devsy. Existing commands and their behavior remain unchanged.

@skevetter skevetter added the rename Loft/Pro rename label Oct 18, 2026
@netlify

netlify Bot commented Oct 18, 2026 •

Copy link
Copy Markdown

✅ Deploy Preview for devsydev canceled.

Name Link
🔨 Latest commit 3b781e6
🔍 Latest deploy log https://app.netlify.com/projects/devsydev/deploys/6ad4fe556185276c29fad3f0

@netlify

netlify Bot commented Oct 18, 2026 •

Copy link
Copy Markdown

✅ Deploy Preview for images-devsy-sh canceled.

Name Link
🔨 Latest commit 3b781e6
🔍 Latest deploy log https://app.netlify.com/projects/images-devsy-sh/deploys/6ad4fe550c3aeb7228eaafd6

@coderabbitai

coderabbitai Bot commented Oct 18, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 9681515e-5ac5-4923-8b5f-ba7e6543890f
📥 Commits

Reviewing files that changed from the base of the PR and between 7b0054f and 3b781e6.

📒 Files selected for processing: 22
  • cmd/pro/cluster/add.go
  • cmd/pro/provider/delete.go
  • cmd/pro/provider/list/clusters.go
  • cmd/pro/provider/list/projects.go
  • cmd/pro/provider/list/templates.go
  • cmd/pro/provider/list/workspaces.go
  • cmd/pro/provider/watch/workspaces.go
  • cmd/pro/user/reset_password.go
  • cmd/pro/workspace/sleep.go
  • cmd/pro/workspace/wakeup.go
  • cmd/workspace/troubleshoot.go
  • pkg/client/clientimplementation/daemonclient/delete.go
  • pkg/client/clientimplementation/daemonclient/stop.go
  • pkg/client/clientimplementation/daemonclient/up.go
  • pkg/daemon/platform/local_server.go
  • pkg/daemon/platform/workspace_watcher.go
  • pkg/platform/client/client.go
  • pkg/platform/instance.go
  • pkg/platform/instance_ops.go
  • pkg/platform/instance_ops_test.go
  • pkg/platform/kube/kube.go
  • pkg/platform/kubeconfig.go

Included review availability: This review used your included allowance. Your plan provides up to 2 included reviews per hour; 0 remain after this review.

📝 Walkthrough

The pull request replaces Loft client access with Devsy client access across CLI commands, platform operations, and daemon code. It also updates the Kubernetes wrapper and related tests to construct and expose Devsy clients. Existing request arguments and surrounding behavior remain unchanged.

Changes: Devsy client migration

Layer / File(s) Summary
Kubernetes client interface
pkg/platform/kube/kube.go, pkg/platform/instance_ops_test.go
The Kubernetes wrapper and test client expose Devsy clients. The instance creation error test uses a Devsy fake client.
CLI management operations
cmd/pro/cluster/add.go, cmd/pro/provider/*, cmd/pro/user/reset_password.go, cmd/pro/workspace/*, cmd/pro/provider/watch/workspaces.go, cmd/workspace/troubleshoot.go
CLI commands use Devsy clients for cluster operations, provider requests, workspace operations, user updates, and troubleshooting.
Platform client operations
pkg/platform/client/client.go, pkg/platform/instance.go, pkg/platform/instance_ops.go, pkg/platform/kubeconfig.go
Platform client, instance, and kubeconfig requests use the Devsy management API client.
Daemon management operations
pkg/client/clientimplementation/daemonclient/*, pkg/daemon/platform/local_server.go, pkg/daemon/platform/workspace_watcher.go
Daemon operations and local server handlers use Devsy clients. The workspace watcher constructs and embeds the Devsy clientset.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~12 minutes

Change: Refactor

Suggested reviewers: fabiankramm

Merge Risk: ⚪ Minimal · up to 3b781

The client rename preserves the existing management operations, so no user-facing behavior change is identified. The PR has no outstanding mergeability concern from this review.

Pre-merge checks: Passed 4 · Failed 1

Failed Failed checks: 1 warning

Check name Status Explanation Resolution
Docstring Coverage Warning Docstring coverage is 20.69% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 29 functions across 22 files. Write docstrings for the functions missing them to satisfy the coverage threshold.
Passed Passed checks: 4 passed
Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title clearly and concisely identifies the main change: renaming the platform kube client accessor from Loft to Devsy.
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
  • Fix all pre-merge checks with AI
✨ Finishing Touches
✨ Simplify code
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@skevetter
skevetter marked this pull request as ready for review October 18, 2026 17:59
@skevetter

Copy link
Copy Markdown
Contributor Author

@coderabbitai review

@mergify

mergify Bot commented Oct 18, 2026 •

Copy link
Copy Markdown

This pull request does not currently match the merge queue conditions, so it cannot be queued from here. The box comes back if it matches again.

@coderabbitai

coderabbitai Bot commented Oct 18, 2026 •

Copy link
Copy Markdown
✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@skevetter
skevetter merged commit 66837e2 into main Oct 18, 2026
111 checks passed
@skevetter
skevetter deleted the refactor/rename-loft-kube-accessor branch October 18, 2026 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

rename Loft/Pro rename size/l

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant