Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/netlify-ops.yml
Original file line number Diff line number Diff line change
Expand Up @@ -152,7 +152,7 @@ jobs:
echo "CUSTOM DOMAIN CONFIGURED: images.devsy.sh"
echo "========================================"
echo ""
echo "DNS action required — add this DNS record:"
echo "DNS action required - add this DNS record:"
echo " Type: CNAME"
echo " Name: images"
echo " Value: ${NETLIFY_SUBDOMAIN}.netlify.app"
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/restore-netlify.yml
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ jobs:
echo "$BODY"
exit 1
fi
echo "Restore API returned HTTP $HTTP_CODE — success"
echo "Restore API returned HTTP $HTTP_CODE - success"

echo ""
echo "Verifying..."
Expand All @@ -63,5 +63,5 @@ jobs:
if [ "$STATUS" = "200" ]; then
echo "SUCCESS: devsy.sh is back online"
else
echo "WARNING: devsy.sh returned $STATUS — may need a few more seconds to propagate"
echo "WARNING: devsy.sh returned $STATUS - may need a few more seconds to propagate"
fi
4 changes: 2 additions & 2 deletions cmd/internal/agentworkspace/delete_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -73,12 +73,12 @@ func TestForceRemoveAll_ReadOnlyDirectory(t *testing.T) {
t.Fatal(err)
}

// Remove write+execute from content dir — simulates what crun does.
// Remove write+execute from content dir - simulates what crun does.
chmodReadOnly(t, content)

// Standard RemoveAll should fail.
if err := os.RemoveAll(target); err == nil {
t.Skip("os.RemoveAll succeeded unexpectedly — filesystem may not enforce permissions")
t.Skip("os.RemoveAll succeeded unexpectedly - filesystem may not enforce permissions")
}

// forceRemoveAll should fix permissions and succeed.
Expand Down
2 changes: 1 addition & 1 deletion cmd/internal/agentworkspace/setup_gpg.go
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,7 @@ func (cmd *SetupGPGCmd) Run(ctx context.Context) error {
return nil
}

// gpgSetupLockMode is 0666 — flock's default 0600 would lock out whichever
// gpgSetupLockMode is 0666 - flock's default 0600 would lock out whichever
// of root/remoteUser did not create the file.
const gpgSetupLockMode = 0o666

Expand Down
2 changes: 1 addition & 1 deletion cmd/internal/git_ssh_signature_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ func (s *GitSSHSignatureTestSuite) TestParseNonSignCommand() {
}

func (s *GitSSHSignatureTestSuite) TestParseMissingBufferFile() {
// All args end in a flag — no buffer file present.
// All args end in a flag - no buffer file present.
args := []string{"-Y", "sign", "-n", "git", "-f", "/path/to/key.pub", "-U"}
result := parseSSHKeygenArgs(args)
assert.Equal(s.T(), "", result.bufferFile)
Expand Down
2 changes: 1 addition & 1 deletion cmd/internal/ssh_server_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,7 @@ func TestEnsureActivityFileCreatesAndIsIdempotent(t *testing.T) {
}

func TestEnsureActivityFileSurfacesNonExistErrors(t *testing.T) {
// Path through a non-directory is ENOTDIR, which is neither nil nor ErrNotExist —
// Path through a non-directory is ENOTDIR, which is neither nil nor ErrNotExist -
// must surface as-is instead of falling into the create branch.
tmp := t.TempDir()
regular := filepath.Join(tmp, "regular")
Expand Down
2 changes: 1 addition & 1 deletion cmd/internal/widen_shared_file.go
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ import (
// NewWidenSharedFileCmd returns a internal command that runs
// sharedfile.WidenIfNeeded. sharedfile.WidenWithSudoFallback re-execs this
// (via sudo) so the actual mode change still goes through WidenIfNeeded's
// open-with-O_NOFOLLOW-then-fchmod, even when it needs root — `sudo chmod
// open-with-O_NOFOLLOW-then-fchmod, even when it needs root - `sudo chmod
// <path>` has no way to refuse following a symlink at path, so re-execing
// into this process is what keeps the escalated path symlink-safe.
func NewWidenSharedFileCmd(globalFlags *flags.GlobalFlags) *cobra.Command {
Expand Down
2 changes: 1 addition & 1 deletion cmd/mcp/buffer.go
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ func (b *BoundedBuffer) Write(p []byte) (int, error) {
n := len(p)
b.written += int64(n)
if len(p) >= b.cap {
// Incoming chunk fills or exceeds cap — keep only the last cap bytes.
// Incoming chunk fills or exceeds cap - keep only the last cap bytes.
b.buf = append(b.buf[:0], p[len(p)-b.cap:]...)
return n, nil
}
Expand Down
2 changes: 1 addition & 1 deletion cmd/mcp/notify.go
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ import (
// long-running tools instead of seeing a single opaque pause.
//
// Lines from goroutines unrelated to fn are also forwarded for the duration
// — acceptable because the only long-running concurrent work the MCP server
// - acceptable because the only long-running concurrent work the MCP server
// kicks off is the call itself.
func streamLogsToSession(
ctx context.Context,
Expand Down
2 changes: 1 addition & 1 deletion cmd/mcp/tools_exec.go
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ func registerExecTool(s *sdkmcp.Server, cmd *ServeCmd, sem *opSemaphore) {
Description: "Run a one-shot command in a running workspace container. The " +
"workspace name must match workspace_list; the workspace must already be " +
"started (use workspace_start if not). 'command' is argv, NOT a shell " +
"string — pass [\"sh\", \"-c\", \"...\"] to use a shell. Each output " +
"string - pass [\"sh\", \"-c\", \"...\"] to use a shell. Each output " +
"stream is capped; long output is truncated tail-only with a marker.",
}, safeHandler(func(
ctx context.Context, _ *sdkmcp.CallToolRequest, in execInput,
Expand Down
2 changes: 1 addition & 1 deletion cmd/mcp/tools_workspace.go
Original file line number Diff line number Diff line change
Expand Up @@ -204,7 +204,7 @@ func registerWorkspaceCreateTool(s *sdkmcp.Server, g *flags.GlobalFlags, sem *op
Name: "workspace_create",
Description: "Create and start a new workspace. May take several minutes on " +
"first use (image pull, git clone, post-create commands); if the call " +
"times out client-side, the server-side operation likely continued — " +
"times out client-side, the server-side operation likely continued - " +
"poll workspace_status to check.\n" +
"\n" +
"source: a git URL (https://, git@host:repo, ssh://, or git:https://... " +
Expand Down
2 changes: 1 addition & 1 deletion cmd/root.go
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ const (

internalCommand = "internal"

rootLong = "Devsy — standardized development workspaces built on devcontainers, " +
rootLong = "Devsy - standardized development workspaces built on devcontainers, " +
"running on Docker, Kubernetes, cloud providers, and SSH remote hosts."

rootExample = `- Start a workspace from the current directory:
Expand Down
8 changes: 4 additions & 4 deletions cmd/snapshot/create.go
Original file line number Diff line number Diff line change
Expand Up @@ -213,7 +213,7 @@ func (cmd *CreateCmd) commitAndPushImage(
// tag right after create, and would otherwise have to re-fetch it
// remotely (pkg/image.GetImage), which doesn't honor this package's
// dockerInternalHost insecure-registry override the way pkg/snapshot's
// own parseReference does — breaking against any plain-HTTP registry
// own parseReference does - breaking against any plain-HTTP registry
// (e.g. the e2e registry:2 fixture). Leaving the local image in place
// avoids that remote round-trip entirely for the common case.
return img, nil
Expand Down Expand Up @@ -307,7 +307,7 @@ type pushedVolumes struct {

// The volumes RPC (StreamSnapshotVolumes) is served by a tunnelServer reading
// directly off local disk, so this only works when the CLI process is
// co-located with those mount source paths — true for the docker driver's
// co-located with those mount source paths - true for the docker driver's
// local bind mounts, the only driver CommitContainer currently supports.
func (cmd *CreateCmd) pushVolumes(
ctx context.Context, workspaceConfig *provider.Workspace, repository string,
Expand Down Expand Up @@ -349,7 +349,7 @@ func (cmd *CreateCmd) pushVolumes(

// credentialKeyPattern matches containerEnv key names that conventionally
// carry a secret value, so they're dropped by redactedContainerEnv even if
// nothing in this codebase injects them today — devcontainer.json's
// nothing in this codebase injects them today - devcontainer.json's
// containerEnv is user-authored and this manifest is pushed to a shared
// registry, so a future entry named e.g. API_TOKEN shouldn't round-trip
// through restore just because dropping it wasn't specifically taught.
Expand Down Expand Up @@ -431,7 +431,7 @@ func newLocalTunnelClient(
// It also re-pushes the same manifest bytes as a plain blob into repository:
// registries store manifests and blobs in separate content stores, and the
// snapshot manifest built in Run references this digest as one of its
// layers[] — a manifest-push validates every layer digest exists as a blob,
// layers[] - a manifest-push validates every layer digest exists as a blob,
// which fails with MANIFEST_BLOB_UNKNOWN without this re-push.
func pushedImageDigestAndSize(
ctx context.Context,
Expand Down
2 changes: 1 addition & 1 deletion cmd/workspace/troubleshoot.go
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@ func (cmd *TroubleshootCmd) Run(ctx context.Context, args []string) {
// Print on every exit path, including panics.
defer printTroubleshootInfo(info)

// Collect as much as possible — partial info beats no info, so do not
// Collect as much as possible - partial info beats no info, so do not
// return early on errors except where downstream steps require the result.
var err error
info.Config, err = config.LoadConfig(cmd.Context, cmd.Provider)
Expand Down
4 changes: 2 additions & 2 deletions cmd/workspace/up/up.go
Original file line number Diff line number Diff line change
Expand Up @@ -639,7 +639,7 @@ func (cmd *UpCmd) executeDevsyUp(
if cmd.Platform.Enabled {
return nil, nil
}
// Guard against a result that lacks the substitution context — that
// Guard against a result that lacks the substitution context - that
// indicates the agent returned a half-populated result (e.g. an inner
// container-setup failure that didn't carry through as result.Error).
// Without this, downstream openIDE would nil-deref on
Expand Down Expand Up @@ -740,7 +740,7 @@ func watchForForceShutdown(ctx context.Context, done <-chan struct{}) {
signal.Notify(signals, shutdownSignals...)
select {
case <-signals:
os.Exit(1) // second signal — force shutdown
os.Exit(1) // second signal - force shutdown
case <-done:
signal.Stop(signals)
}
Expand Down
2 changes: 1 addition & 1 deletion cmd/workspace/up/up_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -330,7 +330,7 @@ func TestBuildUpCmd_DefaultsIDEToNone(t *testing.T) {
t,
"none",
cmd.IDE,
"MCP path must default IDE to none — there's no human to attach an IDE to",
"MCP path must default IDE to none - there's no human to attach an IDE to",
)
}

Expand Down
2 changes: 1 addition & 1 deletion desktop/e2e/electron-app.ts
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ export async function launchApp(): Promise<{
await page.locator('[data-sidebar="sidebar"]').waitFor({ timeout: 10000 })

// Wait for the watcher to poll the mock CLI and populate data
// The watcher polls every 3 seconds — wait for at least one cycle
// The watcher polls every 3 seconds - wait for at least one cycle
await page.waitForTimeout(4000)

return { app, page }
Expand Down
Loading
Loading