Skip to content

chore: normalize dashes and ellipses - #1300

Merged
skevetter merged 2 commits into
mainfrom
chore/normalize-dashes-ellipses
Sep 27, 2026
Merged

skevetter merged 2 commits into
mainfrom
chore/normalize-dashes-ellipses

Conversation

@skevetter

Copy link
Copy Markdown
Contributor

Summary

  • Replace tracked U+2014 em dashes with ASCII hyphen-minus characters.
  • Replace tracked U+2026 ellipses with exactly three ASCII periods.

Validation

  • gofmt -d on changed Go files: clean.
  • task desktop:check: passed with zero errors and warnings.
  • task desktop:test: passed (599 tests).
  • task cli:test: ran; several host/environment-sensitive failures occurred, including the macOS Docker path, test-repository commit signing, Apple container timing, and unavailable Docker/GPU environment.
  • git diff --check: passed; tracked files contain no remaining target characters.

CodeRabbit review could not run because the service rate limit was reached.

@netlify

netlify Bot commented Sep 27, 2026 •

Copy link
Copy Markdown

✅ Deploy Preview for devsydev canceled.

Name Link
🔨 Latest commit 17e7fe1
🔍 Latest deploy log https://app.netlify.com/projects/devsydev/deploys/6ab922a0fb0f0900083b453e

@coderabbitai

coderabbitai Bot commented Sep 27, 2026 •

Copy link
Copy Markdown

Important

Review skipped

Too many files!

This PR contains 133 files, which is 33 over the limit of 100.

To get a review, reduce the PR to 100 files or fewer by splitting it into smaller PRs or changing its base branch.

Upgrade to a paid plan to raise the limit.

This review couldn't start because sufficient usage credits or metered capacity aren't available. Add credits or update usage-based reviews in the billing tab, then retry.

Check out review usage here.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: a3a7cc79-d485-4a24-bc96-fdf0cba87eda

📥 Commits

Reviewing files that changed from the base of the PR and between 0f94c60 and 17e7fe1.

📒 Files selected for processing (133)
  • .github/workflows/netlify-ops.yml
  • .github/workflows/restore-netlify.yml
  • cmd/internal/agentworkspace/delete_test.go
  • cmd/internal/agentworkspace/setup_gpg.go
  • cmd/internal/git_ssh_signature_test.go
  • cmd/internal/ssh_server_test.go
  • cmd/internal/widen_shared_file.go
  • cmd/mcp/buffer.go
  • cmd/mcp/notify.go
  • cmd/mcp/tools_exec.go
  • cmd/mcp/tools_workspace.go
  • cmd/root.go
  • cmd/snapshot/create.go
  • cmd/workspace/troubleshoot.go
  • cmd/workspace/up/up.go
  • cmd/workspace/up/up_test.go
  • desktop/e2e/electron-app.ts
  • desktop/e2e/integration.e2e.ts
  • desktop/e2e/navigation.e2e.ts
  • desktop/e2e/providers.e2e.ts
  • desktop/e2e/workspaces.e2e.ts
  • desktop/src/main/__tests__/tray.test.ts
  • desktop/src/main/cli.ts
  • desktop/src/main/index.ts
  • desktop/src/main/ipc.ts
  • desktop/src/main/tray.ts
  • desktop/src/renderer/src/lib/components/layout/Sidebar.svelte
  • desktop/src/renderer/src/lib/components/log/LogTable.svelte
  • desktop/src/renderer/src/lib/components/provider/ProviderCard.svelte
  • desktop/src/renderer/src/lib/components/provider/ProviderSheet.svelte
  • desktop/src/renderer/src/lib/components/terminal/Terminal.svelte
  • desktop/src/renderer/src/lib/components/update/UpdateDialog.svelte
  • desktop/src/renderer/src/lib/components/update/UpdatesPanel.svelte
  • desktop/src/renderer/src/lib/components/update/UpdatesPanel.test.ts
  • desktop/src/renderer/src/lib/components/update/status-copy.ts
  • desktop/src/renderer/src/lib/components/update/update-toasts.ts
  • desktop/src/renderer/src/lib/components/workspace/ImagePicker.svelte
  • desktop/src/renderer/src/lib/components/workspace/WorkspaceWizard.svelte
  • desktop/src/renderer/src/lib/ipc/bridge.ts
  • desktop/src/renderer/src/lib/ipc/mock.ts
  • desktop/src/renderer/src/lib/stores/settings.ts
  • desktop/src/renderer/src/lib/types/index.ts
  • desktop/src/renderer/src/lib/utils/provider-status.ts
  • desktop/src/renderer/src/pages/MachineDetailPage.svelte
  • desktop/src/shared/cli-error.ts
  • e2e/framework/mcp.go
  • e2e/tests/configread/configread.go
  • e2e/tests/machineprovider/machineprovider.go
  • e2e/tests/rename/rename.go
  • e2e/tests/snapshot/helper.go
  • e2e/tests/ssh/agent_forward.go
  • e2e/tests/ssh/ports_attributes.go
  • e2e/tests/ssh/ssh.go
  • e2e/tests/up-features/up_features.go
  • hack/licenses/third-party-licenses.md.tmpl
  • pkg/agent/snapshot/restore_test.go
  • pkg/agent/tunnelserver/stream.go
  • pkg/agent/tunnelserver/stream_test.go
  • pkg/client/clientimplementation/proxy_client.go
  • pkg/clihelp/help.go
  • pkg/config/pathmanager.go
  • pkg/config/pathmanager_test.go
  • pkg/copy/copy_test.go
  • pkg/daemon/agent/daemon.go
  • pkg/devcontainer/compose_test.go
  • pkg/devcontainer/config/host_requirements.go
  • pkg/devcontainer/config/substitute.go
  • pkg/devcontainer/config/substitute_test.go
  • pkg/devcontainer/config_test.go
  • pkg/devcontainer/feature/features.go
  • pkg/devcontainer/feature/features_integrity_test.go
  • pkg/devcontainer/import_external_test.go
  • pkg/devcontainer/run_test.go
  • pkg/devcontainer/setup/lifecyclehooks.go
  • pkg/devcontainer/setup/lifecyclehooks_test.go
  • pkg/devcontainer/setup/setup_unix_test.go
  • pkg/devcontainer/sshtunnel/sshtunnel.go
  • pkg/devcontainer/sshtunnel/sshtunnel_test.go
  • pkg/driver/docker.go
  • pkg/driver/docker/build_test.go
  • pkg/extract/extract_test.go
  • pkg/git/repo_test.go
  • pkg/gitsshsigning/helper.go
  • pkg/ide/codeserver/codeserver.go
  • pkg/ide/opener/browser_tunnel.go
  • pkg/ide/opener/ide_launch_mode.go
  • pkg/ide/opener/opener.go
  • pkg/ide/opener/opener_test.go
  • pkg/ide/opener/process_alive_unix.go
  • pkg/ide/vscodeweb/vscodeweb.go
  • pkg/image/image.go
  • pkg/image/image_test.go
  • pkg/log/logfmt.go
  • pkg/log/logger.go
  • pkg/machinediagnostics/sanitize.go
  • pkg/machinediagnostics/store_test.go
  • pkg/port/parse.go
  • pkg/provider/env.go
  • pkg/provider/version_cache.go
  • pkg/provider/versions_github.go
  • pkg/provider/workspace.go
  • pkg/sharedfile/sharedfile.go
  • pkg/sharedfile/sharedfile_supported.go
  • pkg/sharedfile/sudo.go
  • pkg/snapshot/reference.go
  • pkg/ssh/server/agent.go
  • pkg/ssh/server/ssh.go
  • pkg/table/table.go
  • pkg/task/task_test.go
  • pkg/workspace/delete_test.go
  • pkg/workspace/rename.go
  • sites/docs-devsy-sh/content/docs/developing-in-workspaces/connect-to-a-workspace.mdx
  • sites/docs-devsy-sh/content/docs/developing-in-workspaces/continuous-integration.mdx
  • sites/docs-devsy-sh/content/docs/developing-in-workspaces/create-a-workspace.mdx
  • sites/docs-devsy-sh/content/docs/developing-in-workspaces/credentials.mdx
  • sites/docs-devsy-sh/content/docs/developing-in-workspaces/devcontainer-json.mdx
  • sites/docs-devsy-sh/content/docs/developing-in-workspaces/mcp-server.mdx
  • sites/docs-devsy-sh/content/docs/developing-in-workspaces/secrets.mdx
  • sites/docs-devsy-sh/content/docs/developing-in-workspaces/workspace-snapshots.mdx
  • sites/docs-devsy-sh/content/docs/developing-providers/binaries.mdx
  • sites/docs-devsy-sh/content/docs/getting-started/install.mdx
  • sites/docs-devsy-sh/content/docs/getting-started/quickstart.mdx
  • sites/docs-devsy-sh/content/docs/how-it-works/overview.mdx
  • sites/docs-devsy-sh/content/docs/managing-providers/manage-providers.mdx
  • sites/docs-devsy-sh/content/docs/managing-providers/what-are-providers.mdx
  • sites/docs-devsy-sh/content/docs/troubleshooting/linux-troubleshooting.mdx
  • sites/docs-devsy-sh/content/docs/troubleshooting/troubleshooting.mdx
  • sites/docs-devsy-sh/content/docs/tutorials/docker-provider-via-wsl.mdx
  • sites/docs-devsy-sh/content/docs/tutorials/podman-provider-setup.mdx
  • sites/docs-devsy-sh/content/docs/tutorials/reduce-build-times-with-cache.mdx
  • sites/docs-devsy-sh/content/docs/what-is-devsy.mdx
  • sites/docs-devsy-sh/uml/up_sequence.puml
  • sites/images-devsy-sh/src/components/SearchBar.svelte

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@netlify

netlify Bot commented Sep 27, 2026 •

Copy link
Copy Markdown

✅ Deploy Preview for images-devsy-sh canceled.

Name Link
🔨 Latest commit 17e7fe1
🔍 Latest deploy log https://app.netlify.com/projects/images-devsy-sh/deploys/6ab922a07e22150008499745

@skevetter
skevetter marked this pull request as ready for review September 27, 2026 15:38
@mergify

mergify Bot commented Sep 27, 2026 •

Copy link
Copy Markdown

This pull request does not currently match the merge queue conditions, so it cannot be queued from here. The box comes back if it matches again.

@skevetter
skevetter merged commit 981c6a7 into main Sep 27, 2026
89 checks passed
@skevetter
skevetter deleted the chore/normalize-dashes-ellipses branch September 27, 2026 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant