V2 New features

.azure/pipelines/ci.yml

@@ -59,66 +59,66 @@ stages:
               DOTNET_CLI_TELEMETRY_OPTOUT: 1
               DOTNET_NOLOGO: 1
 
-  - stage: "integration_testing"
-    displayName: "Integration testing"
-    dependsOn: []
-    condition: eq(variables['RunIntegrationTestingStage'], true)
-    jobs:
-      - job: "windows_integrationtests"
-        displayName: "Windows CI"
-        pool:
-          vmImage: "windows-latest"
-        steps:
-          - task: UseDotNet@2
-            displayName: "Use .NET Core SDK"
-            inputs:
-              packageType: "sdk"
-              version: $(dotnet.sdk.version)
-          - task: PowerShell@2
-            displayName: "Start local MongoDB"
-            inputs:
-              targetType: "inline"
-              script: |
-                Write-Host "Starting MongoDB"
-                md log
-                md data
-                Start-Process -FilePath "mongod" -ArgumentList "--logpath log/mongod.log", "--dbpath data", "--port 27017" -WindowStyle Hidden
-          - task: DotNetCoreCLI@2
-            displayName: "Restore .NET packages"
-            inputs:
-              command: "restore"
-              projects: "$(SolutionFile)"
-              feedsToUse: "select"
-              noCache: $(dotnet.cache.disable)
-            env:
-              DOTNET_CLI_TELEMETRY_OPTOUT: 1
-              DOTNET_NOLOGO: 1
-          - task: DotNetCoreCLI@2
-            displayName: "Build .NET solution"
-            inputs:
-              command: "build"
-              projects: "$(SolutionFile)"
-              arguments: "-c $(BuildConfiguration)"
-            env:
-              DOTNET_CLI_TELEMETRY_OPTOUT: 1
-              DOTNET_NOLOGO: 1
-          - task: DotNetCoreCLI@2
-            displayName: "Run .NET test projects"
-            inputs:
-              command: "test"
-              projects: "$(TestProjects)"
-              arguments: '--configuration $(BuildConfiguration) --report-xunit-trx --coverage --coverage-output-format cobertura -- --filter-query "/[(Category=UnitTests)|(Mode=Readonly)]"'
-            env:
-              AllowedOrigins__0: "5207"
-              Features__IsScalarEnabled: true
-              Features__IsHttpsRedirectionEnabled: false
-              ASPNETCORE_ENVIRONMENT: Development
-              DOTNET_CLI_TELEMETRY_OPTOUT: 1
-              DOTNET_NOLOGO: 1
-          - task: PublishBuildArtifacts@1
-            displayName: "Publish artifacts"
-            condition: failed()
-            inputs:
-              PathtoPublish: "$(Build.ArtifactStagingDirectory)"
-              ArtifactName: "drop"
-              publishLocation: "Container"
+#  - stage: "integration_testing"
+#    displayName: "Integration testing"
+#    dependsOn: []
+#    condition: eq(variables['RunIntegrationTestingStage'], true)
+#    jobs:
+#      - job: "windows_integrationtests"
+#        displayName: "Windows CI"
+#        pool:
+#          vmImage: "windows-latest"
+#        steps:
+#          - task: UseDotNet@2
+#            displayName: "Use .NET Core SDK"
+#            inputs:
+#              packageType: "sdk"
+#              version: $(dotnet.sdk.version)
+#          - task: PowerShell@2
+#            displayName: "Start local MongoDB"
+#            inputs:
+#              targetType: "inline"
+#              script: |
+#                Write-Host "Starting MongoDB"
+#                md log
+#                md data
+#                Start-Process -FilePath "mongod" -ArgumentList "--logpath log/mongod.log", "--dbpath data", "--port 27017" -WindowStyle Hidden
+#          - task: DotNetCoreCLI@2
+#            displayName: "Restore .NET packages"
+#            inputs:
+#              command: "restore"
+#              projects: "$(SolutionFile)"
+#              feedsToUse: "select"
+#              noCache: $(dotnet.cache.disable)
+#            env:
+#              DOTNET_CLI_TELEMETRY_OPTOUT: 1
+#              DOTNET_NOLOGO: 1
+#          - task: DotNetCoreCLI@2
+#            displayName: "Build .NET solution"
+#            inputs:
+#              command: "build"
+#              projects: "$(SolutionFile)"
+#              arguments: "-c $(BuildConfiguration)"
+#            env:
+#              DOTNET_CLI_TELEMETRY_OPTOUT: 1
+#              DOTNET_NOLOGO: 1
+#          - task: DotNetCoreCLI@2
+#            displayName: "Run .NET test projects"
+#            inputs:
+#              command: "test"
+#              projects: "$(TestProjects)"
+#              arguments: '--configuration $(BuildConfiguration) --report-xunit-trx --coverage --coverage-output-format cobertura -- --filter-query "/[(Category=UnitTests)|(Mode=Readonly)]"'
+#            env:
+#              AllowedOrigins__0: "5207"
+#              Features__IsScalarEnabled: true
+#              Features__IsHttpsRedirectionEnabled: false
+#              ASPNETCORE_ENVIRONMENT: Development
+#              DOTNET_CLI_TELEMETRY_OPTOUT: 1
+#              DOTNET_NOLOGO: 1
+#          - task: PublishBuildArtifacts@1
+#            displayName: "Publish artifacts"
+#            condition: failed()
+#            inputs:
+#              PathtoPublish: "$(Build.ArtifactStagingDirectory)"
+#              ArtifactName: "drop"
+#              publishLocation: "Container"

.editorconfig

@@ -6,7 +6,7 @@ root = true
 end_of_line = lf
 insert_final_newline = true
 indent_style = space
-max_line_length = 150
+max_line_length = 180
 
 [*.{cs,razor,sln}]
 indent_size = 4
@@ -19,6 +19,7 @@ trim_trailing_whitespace = true
 [*.md]
 indent_size = 2
 trim_trailing_whitespace = false
+max_line_length = 240
 
 [*.cs]
 dotnet_sort_system_directives_first = true
@@ -152,3 +153,7 @@ csharp_space_between_square_brackets = false
 csharp_prefer_braces = true:silent
 csharp_preserve_single_line_blocks = true
 csharp_preserve_single_line_statements = true
+# Mapperly configuration drift (an unmapped source or target member on a [Mapper] class) must fail the build, the way AutoMapperConfigurationTest's AssertConfigurationIsValid() used to fail the test run
+# before it was deleted - see docs/automapper-removal-plan.md.
+dotnet_diagnostic.RMG012.severity = error
+dotnet_diagnostic.RMG020.severity = error

.github/workflows/ci.yaml

@@ -4,9 +4,11 @@
 
 on:
   push:
-    branches: [ main ]
+    branches:
+      - main
   pull_request:
-    branches: [ main ]
+    branches:
+      - main
   workflow_dispatch:
     inputs:
       run-code-quality:
@@ -37,13 +39,13 @@ jobs:
 
   markup-lint:
     name: Markup
-    uses: devpro/github-workflow-parts/.github/workflows/reusable-markup-lint.yml@c90ba46a93ca90123f57744b47e49c1a73962cea
+    uses: devpro/github-workflow-parts/.github/workflows/reusable-markup-lint.yml@f9d8c00db1ed723e39cfff6c4c7addc77a23c54d
 
   code-quality:
     name: Code
     needs: git-check
     if: needs.git-check.outputs.app_changed == 'true' || (github.event_name == 'workflow_dispatch' && inputs.run-code-quality)
-    uses: devpro/github-workflow-parts/.github/workflows/reusable-dotnet-quality.yml@c90ba46a93ca90123f57744b47e49c1a73962cea
+    uses: devpro/github-workflow-parts/.github/workflows/reusable-dotnet-quality.yml@f9d8c00db1ed723e39cfff6c4c7addc77a23c54d
     with:
       custom-commands: |
         ./scripts/mongodb-install.sh
@@ -58,18 +60,21 @@ jobs:
         Infrastructure__MongoDB__DatabaseName=keeptrack_ci
       fossa-enabled: true
       sonar-enabled: true
-      sonar-exclusions: "samples/**"
+      sonar-exclusions: "samples/**,**/*.g.cs,**/*.generated.cs"
       sonar-organization: ${{ vars.SONAR_ORG }}
       sonar-project-key: ${{ vars.SONAR_PROJECT_KEY }}
       sonar-project-name: Keeptrack
-      workflow-parts-version: c90ba46a93ca90123f57744b47e49c1a73962cea
+      workflow-parts-version: f9d8c00db1ed723e39cfff6c4c7addc77a23c54d
     secrets:
       fossa-api-key: ${{ secrets.FOSSA_API_KEY }}
       sonar-token: ${{ secrets.SONAR_TOKEN }}
       additional-vars: |
         Authentication__JwtBearer__Authority=https://securetoken.google.com/${{ secrets.FIREBASE_PROJECTID }}
         Authentication__JwtBearer__TokenValidation__Issuer=https://securetoken.google.com/${{ secrets.FIREBASE_PROJECTID }}
         Authentication__JwtBearer__TokenValidation__Audience=${{ secrets.FIREBASE_PROJECTID }}
+        Tmdb__ApiKey=${{ secrets.TMDB_APIKEY }}
+        Rawg__ApiKey=${{ secrets.RAWG_APIKEY }}
+        Discogs__Token=${{ secrets.DISCOGS_TOKEN }}
         FIREBASE_APIKEY=${{ secrets.FIREBASE_APIKEY }}
         FIREBASE_USERNAME=${{ secrets.FIREBASE_TESTUSERNAME }}
         FIREBASE_PASSWORD=${{ secrets.FIREBASE_TESTPASSWORD }}
@@ -90,7 +95,7 @@ jobs:
           - name: "Web Api"
             image-name: "keeptrack-webapi"
             image-definition: "src/WebApi/Dockerfile"
-    uses: devpro/github-workflow-parts/.github/workflows/reusable-container-scan.yml@c90ba46a93ca90123f57744b47e49c1a73962cea
+    uses: devpro/github-workflow-parts/.github/workflows/reusable-container-scan.yml@f9d8c00db1ed723e39cfff6c4c7addc77a23c54d
     with:
       image-definition: ${{ matrix.image-definition }}
       image-name: ${{ matrix.image-name }}

.github/workflows/pkg.yaml

@@ -28,7 +28,7 @@ jobs:
     permissions:
       id-token: write
       contents: read
-    uses: devpro/github-workflow-parts/.github/workflows/reusable-container-publication.yml@c90ba46a93ca90123f57744b47e49c1a73962cea
+    uses: devpro/github-workflow-parts/.github/workflows/reusable-container-publication.yml@f9d8c00db1ed723e39cfff6c4c7addc77a23c54d
     with:
       create-latest: ${{ github.ref_name == 'main' }}
       image-definition: ${{ matrix.image-definition }}

.gitignore

@@ -17,3 +17,6 @@ Local.runsettings
 # NPM
 firebase.config.js
 node_modules/
+
+# Logs
+*.log

.markdownlint-cli2.yaml

@@ -1,4 +1,4 @@
-gitignore: true
+gitignore: true
 ignores:
   - "**/node_modules/**"
 config: